From: Johan Hovold <johan@kernel.org>
To: Helge Deller <deller@gmx.de>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: ftdi_sio: Fix serial port stall after resume
Date: Tue, 27 Oct 2020 10:00:43 +0100 [thread overview]
Message-ID: <20201027090043.GG4085@localhost> (raw)
In-Reply-To: <1aefc37b-8976-efda-f397-2d9492b1260a@gmx.de>
On Thu, Oct 08, 2020 at 08:16:02PM +0200, Helge Deller wrote:
> On 10/8/20 5:21 PM, Johan Hovold wrote:
> > On Tue, Sep 29, 2020 at 09:33:27PM +0200, Helge Deller wrote:
> >> With a 4-port serial USB HUB with FT232BM chips the serial ports stop
> >> working after a software suspend/resume cycle.
> >> Rewriting the latency timer during the resume phase fixes it.
> >> +static int ftdi_reset_resume(struct usb_serial *serial)
> >> +{
> >> + struct usb_serial_port *port = serial->port[0];
> >> +
> >> + if (tty_port_initialized(&port->port))
> >> + write_latency_timer(port);
> >
> > Why are you only doing this for open ports?
>
> I more or less copied it from another driver....
>
> >> +
> >> + return usb_serial_generic_resume(serial);
> >> +}
> >
> > And if the device has been reset there may need to reconfigured the
> > termios settings for open ports.
> >
> > Could you expand a bit on what the problem is here?
>
> My testcase is pretty simple:
> 1. I use e.g. "minicom -D /dev/ttyUSB2". Serial connection works.
> 2. I exit minicom.
> 3. I suspend the workstation: "systemctl suspend"
> 4. I wake up the machine and wait a few seconds.
> 5. I start "minicom -D /dev/ttyUSB2" again. No transfers on the serial port.
>
> With my patch the minicom serial communications does work.
> Another way to wake up the connection is to rmmod the driver and
> insmod it again.
Weird indeed. If you exit minicom before suspend and no other process is
keeping the port open, then that write_latency_timer() above would never
be executed.
Could you enable some debugging and provide a dmesg log from a test
cycle (open/close minicom, suspend/resume, open minicom)?
echo file usb-serial.c +p > /sys/kernel/debug/dynamic_debug/control
Johan
next prev parent reply other threads:[~2020-10-27 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 19:33 [PATCH] USB: serial: ftdi_sio: Fix serial port stall after resume Helge Deller
2020-10-08 15:21 ` Johan Hovold
2020-10-08 18:16 ` Helge Deller
2020-10-27 9:00 ` Johan Hovold [this message]
2020-10-28 14:54 ` Helge Deller
2020-10-28 15:01 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027090043.GG4085@localhost \
--to=johan@kernel.org \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).