From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21E0C4332F for ; Tue, 11 Oct 2022 05:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbiJKFp7 (ORCPT ); Tue, 11 Oct 2022 01:45:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiJKFp6 (ORCPT ); Tue, 11 Oct 2022 01:45:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDFC51EEFC for ; Mon, 10 Oct 2022 22:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665467156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mDLip3zeejmnkhQb+7KaEyxp3L0KOSICdhVmdqjYG3k=; b=MGlF0dqT33/Rr3VrOm1Rkux/ifisCHdo2aAZJRCxZyGOU8l9HktYnKIdngMrejBxB1krQM x2VY+quty/jHSLBjvsgoef/923diMf6cWr3KxGG+r5Xup9jkrp4nj2WxZHEXhAL/uSLOSO K2ui3KgLfvcPDDFvs3EfM9W+mXukBsQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-OgahoQadP1OS0h1KxdBUYg-1; Tue, 11 Oct 2022 01:45:52 -0400 X-MC-Unique: OgahoQadP1OS0h1KxdBUYg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1CB6F185A794; Tue, 11 Oct 2022 05:45:52 +0000 (UTC) Received: from niphredil.zaitcev.lan (unknown [10.2.17.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85A2DA37D0; Tue, 11 Oct 2022 05:45:51 +0000 (UTC) Date: Tue, 11 Oct 2022 00:45:50 -0500 From: Pete Zaitcev To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Juergen Stuber , Johan Hovold Subject: Re: [PATCH] USB: make devnode() callback in usb_class_driver take a const * Message-ID: <20221011004550.46e068f5@niphredil.zaitcev.lan> In-Reply-To: <20221001165128.2688526-1-gregkh@linuxfoundation.org> References: <20221001165128.2688526-1-gregkh@linuxfoundation.org> Organization: Red Hat, Inc. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, 1 Oct 2022 18:51:28 +0200 Greg Kroah-Hartman wrote: > +++ b/drivers/usb/class/usblp.c > @@ -1090,7 +1090,7 @@ static const struct file_operations usblp_fops = { > -static char *usblp_devnode(struct device *dev, umode_t *mode) > +static char *usblp_devnode(const struct device *dev, umode_t *mode) > { > return kasprintf(GFP_KERNEL, "usb/%s", dev_name(dev)); > } Seems obvious. Acked-by: Pete Zaitcev -- P