From: Oliver Neukum <oneukum@suse.com>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
kuba@kernel.org, bjorn@mork.no
Subject: Re: [RFC net-next 1/2] usb: class: cdc-wdm: add control type
Date: Fri, 30 Apr 2021 12:32:05 +0200 [thread overview]
Message-ID: <61b189cfd64e6d2a185ffc0178265caa693fa735.camel@suse.com> (raw)
In-Reply-To: <1619777783-24116-1-git-send-email-loic.poulain@linaro.org>
Am Freitag, den 30.04.2021, 12:16 +0200 schrieb Loic Poulain:
> Add type parameter to usb_cdc_wdm_register function in order to
> specify which control protocol the cdc-wdm channel is transporting.
> It will be required for exposing the channel(s) through WWAN framework.
Hi,
that is an interesting framework.
Some issues though.
Regards
Oliver
> +/**
> + * enum usb_cdc_wdm_type - CDC WDM endpoint type
> + * @USB_CDC_WDM_UNKNOWN: Unknown type
> + * @USB_CDC_WDM_MBIM: Mobile Broadband Interface Model control
> + * @USB_CDC_WDM_QMI: Qualcomm Modem Interface for modem control
> + * @USB_CDC_WDM_AT: AT commands interface
> + */
> +enum usb_cdc_wdm_type {
> + USB_CDC_WDM_UNKNOWN,
> + USB_CDC_WDM_MBIM,
> + USB_CDC_WDM_QMI,
> + USB_CDC_WDM_AT
> +};
If this is supposed to integrate CDC-WDM into a larger subsystem, what
use are private types here? If you do this the protocols need to come
from the common framework.
prev parent reply other threads:[~2021-04-30 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 10:16 [RFC net-next 1/2] usb: class: cdc-wdm: add control type Loic Poulain
2021-04-30 10:16 ` [RFC net-next 2/2] usb: class: cdc-wdm: WWAN framework integration Loic Poulain
2021-04-30 10:39 ` Oliver Neukum
2021-05-01 10:49 ` Bjørn Mork
2021-05-03 7:47 ` Loic Poulain
2021-04-30 10:32 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61b189cfd64e6d2a185ffc0178265caa693fa735.camel@suse.com \
--to=oneukum@suse.com \
--cc=bjorn@mork.no \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).