From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,4/5] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled From: Felipe Balbi Message-Id: <87mukes1dd.fsf@linux.intel.com> Date: Thu, 25 Apr 2019 15:41:50 +0300 To: Douglas Anderson , Minas Harutyunyan , heiko@sntech.de Cc: Alan Stern , Artur Petrosyan , amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay , jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org List-ID: RG91Z2xhcyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPiB3cml0ZXM6Cgo+IElmIHRo ZSAnc25wcyxuZWVkLXBoeS1mb3Itd2FrZScgaXMgc2V0IGluIHRoZSBkZXZpY2UgdHJlZSB0aGVu Ogo+Cj4gLSBXZSBrbm93IHRoYXQgd2UgY2FuIHdha2V1cCwgc28gY2FsbCBkZXZpY2Vfc2V0X3dh a2V1cF9jYXBhYmxlKCkuCj4gICBUaGUgVVNCIGNvcmUgd2lsbCB1c2UgdGhpcyBrbm93bGVkZ2Ug dG8gZW5hYmxlIHdha2V1cCBieSBkZWZhdWx0Lgo+IC0gV2Uga25vdyB0aGF0IHdlIHNob3VsZCBr ZWVwIHRoZSBQSFkgb24gZHVyaW5nIHN1c3BlbmQgaWYgc29tZXRoaW5nCj4gICBvbiBvdXIgcm9v dCBodWIgbmVlZHMgcmVtb3RlIHdha2V1cC4gIFRoaXMgcmVxdWlyZXMgdGhlIHBhdGNoIChVU0I6 Cj4gICBFeHBvcnQgdXNiX3dha2V1cF9lbmFibGVkX2Rlc2NlbmRhbnRzKCkpLiAgTm90ZSB0aGF0 IHdlIGRvbid0IGtlZXAKPiAgIHRoZSBQSFkgb24gYXQgc3VzcGVuZCB0aW1lIGlmIGl0J3Mgbm90 IG5lZWRlZCBiZWNhdXNlIGl0IHdvdWxkIGJlIGEKPiAgIHBvd2VyIGRyYXcuCj4KPiBJZiB3ZSBs YXRlciBmaW5kIHNvbWUgdXNlcnMgb2YgZHdjMiB0aGF0IGNhbiBzdXBwb3J0IHdha2V1cCB3aXRo b3V0Cj4ga2VlcGluZyB0aGUgUEhZIG9uIHdlIG1heSB3YW50IHRvIGFkZCBhIHdheSB0byBjYWxs Cj4gZGV2aWNlX3NldF93YWtldXBfY2FwYWJsZSgpIHdpdGhvdXQga2VlcGluZyB0aGUgUEhZIG9u IGF0IHN1c3BlbmQKPiB0aW1lLgo+Cj4gU2lnbmVkLW9mZi1ieTogRG91Z2xhcyBBbmRlcnNvbiA8 ZGlhbmRlcnNAY2hyb21pdW0ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFpob25nIDx6eXdA cm9jay1jaGlwcy5jb20+CgpjaGVja2luZyBmaWxlIGRyaXZlcnMvdXNiL2R3YzIvY29yZS5oCkh1 bmsgIzEgRkFJTEVEIGF0IDg2MS4KSHVuayAjMiBGQUlMRUQgYXQgMTA0OS4KMiBvdXQgb2YgMiBo dW5rcyBGQUlMRUQKY2hlY2tpbmcgZmlsZSBkcml2ZXJzL3VzYi9kd2MyL3BsYXRmb3JtLmMKSHVu ayAjMyBGQUlMRUQgYXQgNDg3LgpIdW5rICM0IHN1Y2NlZWRlZCBhdCA1MTMgKG9mZnNldCAtOSBs aW5lcykuCkh1bmsgIzUgc3VjY2VlZGVkIGF0IDU0MyAob2Zmc2V0IC05IGxpbmVzKS4KSHVuayAj NiBzdWNjZWVkZWQgYXQgNTU2IChvZmZzZXQgLTkgbGluZXMpLgoxIG91dCBvZiA2IGh1bmtzIEZB SUxFRAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DC0C282E1 for ; Thu, 25 Apr 2019 12:42:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D2B120644 for ; Thu, 25 Apr 2019 12:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728671AbfDYMmB (ORCPT ); Thu, 25 Apr 2019 08:42:01 -0400 Received: from mga03.intel.com ([134.134.136.65]:62207 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbfDYMmA (ORCPT ); Thu, 25 Apr 2019 08:42:00 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 05:42:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,393,1549958400"; d="asc'?scan'208";a="134292877" Received: from pipin.fi.intel.com (HELO pipin) ([10.237.72.175]) by orsmga007.jf.intel.com with ESMTP; 25 Apr 2019 05:41:54 -0700 From: Felipe Balbi To: Douglas Anderson , Minas Harutyunyan , heiko@sntech.de Cc: Alan Stern , Artur Petrosyan , amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay , jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang , Douglas Anderson , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled In-Reply-To: <20190418001356.124334-5-dianders@chromium.org> References: <20190418001356.124334-1-dianders@chromium.org> <20190418001356.124334-5-dianders@chromium.org> Date: Thu, 25 Apr 2019 15:41:50 +0300 Message-ID: <87mukes1dd.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190425124150.ft8ccG4QR6YEgy9xFS4215s5Xp4nUtQBQZpu7gd6BaY@z> --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Douglas Anderson writes: > If the 'snps,need-phy-for-wake' is set in the device tree then: > > - We know that we can wakeup, so call device_set_wakeup_capable(). > The USB core will use this knowledge to enable wakeup by default. > - We know that we should keep the PHY on during suspend if something > on our root hub needs remote wakeup. This requires the patch (USB: > Export usb_wakeup_enabled_descendants()). Note that we don't keep > the PHY on at suspend time if it's not needed because it would be a > power draw. > > If we later find some users of dwc2 that can support wakeup without > keeping the PHY on we may want to add a way to call > device_set_wakeup_capable() without keeping the PHY on at suspend > time. > > Signed-off-by: Douglas Anderson > Signed-off-by: Chris Zhong checking file drivers/usb/dwc2/core.h Hunk #1 FAILED at 861. Hunk #2 FAILED at 1049. 2 out of 2 hunks FAILED checking file drivers/usb/dwc2/platform.c Hunk #3 FAILED at 487. Hunk #4 succeeded at 513 (offset -9 lines). Hunk #5 succeeded at 543 (offset -9 lines). Hunk #6 succeeded at 556 (offset -9 lines). 1 out of 6 hunks FAILED =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlzBqw4ACgkQzL64meEa mQbVCxAApSaX0S5csF9prSld7aWLI8sHAR7AKO7ORr1SGmtZrsW/68If6MgGPheM GRpQpq+UhyxqXnwUm3jcn+DXWaYC4p1K0r/SCksJRiUiF1CaxW46IH7fuCtYLqcD SQWTEg6Co8rpLXNe6YWAiGiT1Z1cFyL2CFZKiy6jn5yN3jd3nIpbGs4gFpc0GAzp mm1RJL1iSkuuDKm8+SlAcLAxxn/l2ARFMthzVvDSvwcFUmhpZyK15KkH5NFBZuEX m+aIz75H2Cd7hwhOvKiV+3UahD6VlOBV9Va8GaQv5MHsm3Cris7L2+PzUK6289BK slOQyh/X5xSPyixnbQ7ytEgC9+h4mgSwHJAdbTfkU1GHSvse/DhkKF9lLM7AcaRh EdF2MdIeeyqyHx0OrdMvoBGWHhy2m8C04dW2+YBKeIFEwhfZkPkw1SvIwpo7f8It ffTghKVOjYaK/TbR5ohAesqo+/yKmG+GgmfQZlcQ6sFALVBxmj+aaFSMo6R125j8 CvH3zVfXYsgnz4iYcKkz1VXyddu0NDD0Ml6A1L7pq1dwxINaukkk68QyC9euMAF0 SdsGIGIWl20/2tDKjtkTzIdRujTnDPbNqiiOyMviQvo30KxZcfNMPzMtV96MJ13U X5PjJyRNxe4yULEUuXrnGCvTwD/mIif/3OJfh6n0SW28cD2A/dA= =+55D -----END PGP SIGNATURE----- --=-=-=--