From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: Marek Vasut <marex@denx.de>,
Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: Amelie Delaunay <amelie.delaunay@st.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] [RFC] usb: dwc2: Run the core connect in dwc2_hcd_init()
Date: Mon, 13 Apr 2020 15:27:54 +0000 [thread overview]
Message-ID: <9906c2da-8a20-eae7-d69e-6947085edf84@synopsys.com> (raw)
In-Reply-To: <b20fb33d-7fdd-5785-8f72-74900eb4d328@denx.de>
Hi,
On 4/13/2020 6:54 PM, Marek Vasut wrote:
> On 4/13/20 4:45 PM, Minas Harutyunyan wrote:
>> Hi,
>
> Hi,
>
>> On 4/13/2020 6:31 PM, Marek Vasut wrote:
>>> On STM32MP1 without the STUSB1600 USB-C chip (i.e. with plain USB-OTG
>>
>> Could you please provide GSNPSID, GHWCFG1-4 register values for STM32MP1.
>
> GSNPSID = 0x4f54330a
> GHWCFG1 = 0x00000000
> GHWCFG2 = 0x228fe150
> GHWCFG3 = 0x03b892e8
> GHWCFG4 = 0xe3f00030
>
STM32MP1 core doesn't support ACG feature: GHWCFG4_ACG_SUPPORTED = 0.
So, in your patch for STM32MP1 at least these lines are no meaning:
+ /* Enable ACG feature in device mode,if supported */
+ dwc2_enable_acg(hsotg);
Looks like you just copied this chirp from dwc2_conn_id_status_change()
function.
dwc2_hsotg_core_init_disconnected() function is device mode function,
not sure that it's safe to call it for host mode in dwc2_hcd_init().
Thanks,
Minas
next prev parent reply other threads:[~2020-04-13 15:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 14:31 [PATCH] [RFC] usb: dwc2: Run the core connect in dwc2_hcd_init() Marek Vasut
2020-04-13 14:45 ` Minas Harutyunyan
2020-04-13 14:54 ` Marek Vasut
2020-04-13 15:27 ` Minas Harutyunyan [this message]
2020-04-13 17:00 ` Marek Vasut
2020-04-14 7:14 ` Minas Harutyunyan
2020-04-14 12:18 ` Marek Vasut
2020-04-15 8:37 ` Minas Harutyunyan
2020-04-15 14:55 ` Marek Vasut
2020-04-15 15:10 ` Minas Harutyunyan
2020-04-16 9:46 ` Marek Vasut
2020-04-16 13:37 ` Minas Harutyunyan
2020-04-16 14:31 ` Marek Vasut
2020-04-17 9:00 ` Minas Harutyunyan
2020-04-20 12:09 ` Marek Vasut
2020-04-22 13:45 ` Minas Harutyunyan
2020-04-22 14:21 ` Marek Vasut
2020-05-14 0:10 ` Marek Vasut
2020-05-15 7:41 ` Minas Harutyunyan
2020-05-27 6:17 ` Minas Harutyunyan
2020-05-28 22:35 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9906c2da-8a20-eae7-d69e-6947085edf84@synopsys.com \
--to=minas.harutyunyan@synopsys.com \
--cc=amelie.delaunay@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).