linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@nxp.com>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
	"rogerq@ti.com" <rogerq@ti.com>,
	"nsekhar@ti.com" <nsekhar@ti.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v3] usb: cdns3: Variable 'length' set but not used
Date: Wed, 28 Oct 2020 07:35:52 +0000	[thread overview]
Message-ID: <AM8PR04MB7300CE054149183918FF5C2F8B170@AM8PR04MB7300.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DM6PR07MB55296E10F720D4B7431663A4DD170@DM6PR07MB5529.namprd07.prod.outlook.com>

 
> 
> >
> >> Peter,
> >>
> >> It looks like you missed the " [PATCH v3] usb: cdns3: Variable
> >> 'length' set but not used"
> >>
> >> It's quite important because compiler complains for this when I use W=1.
> >>
> >
> >Pawel, it is the bug-fix, and located at branch: for-usb-fixes.
> 
> But I can't see it in this branch:
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kern
> el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fpeter.chen%2Fusb.git%2Flo
> g%2F%3Fh%3Dfor-usb-fixes%26qt%3Dgrep%26q%3Dcdns3&amp;data=04%7C
> 01%7Cpeter.chen%40nxp.com%7Cc49c80ded3ec4bae70aa08d87b120467%7C
> 686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637394664604902329%7
> CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBT
> iI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=jtcT0U8ZptlBSwST00%2B
> bMtCQDZDr%2B3PNMm69RrZWgDs%3D&amp;reserved=0
> 
> I can see there only: usb: cdns3: Rids of duplicate error message.
> 

Thanks for notifying it, I have updated it.

Peter

> >
> >> Thanks,
> >> Pawel
> >>
> >> >> >
> >> >> > A gentle ping.
> >> >> >
> >> >> > I assume that you should add this and the rest overdue cdsn3
> >> >> > patches as first to you ci-for-usb-next branch.
> >> >> > Am I right?
> >> >> >
> >> >>
> >> >> Hi Pawel,
> >> >>
> >> >> I queued them locally, and I waited for v5.10-rc1 which was out
> >> >> yesterday, then I will apply them, and add cdns3 patches to my
> >> >> kernel.org branch. Will update you these two days.
> >> >>
> >> >> Peter
> >> >
> >> >Hi Pawel,
> >> >
> >> >The cdns3 -next patches pushed to: for-usb-next; cdns3 -fixes
> >> >patches pushed
> >> to: for-usb-fixes.
> >> >The git is:
> >> >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git
> >> >
> >> >Currently, I only pushed three of your patches, would you please
> >> >review my
> >> patches, thanks.
> >> >
> >> >Peter

      reply	other threads:[~2020-10-29  1:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  4:55 [PATCH v3] usb: cdns3: Variable 'length' set but not used Pawel Laszczak
2020-10-26  9:47 ` Pawel Laszczak
2020-10-26 11:55   ` Peter Chen
2020-10-27  3:58     ` Peter Chen
2020-10-27 12:08       ` Pawel Laszczak
2020-10-28  6:44         ` Peter Chen
2020-10-28  7:20           ` Pawel Laszczak
2020-10-28  7:35             ` Peter Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM8PR04MB7300CE054149183918FF5C2F8B170@AM8PR04MB7300.eurprd04.prod.outlook.com \
    --to=peter.chen@nxp.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kurahul@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=pawell@cadence.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).