From: Pawel Laszczak <pawell@cadence.com>
To: Peter Chen <peter.chen@nxp.com>, Roger Quadros <rogerq@ti.com>
Cc: "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"nsekhar@ti.com" <nsekhar@ti.com>,
Rahul Kumar <kurahul@cadence.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] usb: cdns3: gadget: Fix full-speed mode
Date: Wed, 16 Oct 2019 04:35:39 +0000 [thread overview]
Message-ID: <BYAPR07MB470974072BDED3F032E35F80DD920@BYAPR07MB4709.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20191008080711.GH5670@b29397-desktop>
>On 19-10-07 15:16:01, Roger Quadros wrote:
>> We need to disable USB3 PHY for full-speed mode else
>> gadget mode is broken.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
>> drivers/usb/cdns3/gadget.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
>> index 228cdc4ab886..157536753b8c 100644
>> --- a/drivers/usb/cdns3/gadget.c
>> +++ b/drivers/usb/cdns3/gadget.c
>> @@ -2571,6 +2571,7 @@ static int cdns3_gadget_start(struct cdns3 *cdns)
>> switch (max_speed) {
>> case USB_SPEED_FULL:
>> writel(USB_CONF_SFORCE_FS, &priv_dev->regs->usb_conf);
>> + writel(USB_CONF_USB3DIS, &priv_dev->regs->usb_conf);
>> break;
>> case USB_SPEED_HIGH:
>> writel(USB_CONF_USB3DIS, &priv_dev->regs->usb_conf);
>
>Reviewed-by: Peter Chen <peter.chen@nxp.com>
Reviewed-by: Pawel Laszczak <pawell@cadence.com>
>
>--
>
>Thanks,
>Peter Chen
Regards,
Pawell
prev parent reply other threads:[~2019-10-16 4:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 12:15 [PATCH 0/2] usb: cdns3: fixes for 5.4-rc Roger Quadros
2019-10-07 12:16 ` [PATCH 1/2] usb: cdns3: fix cdns3_core_init_role() Roger Quadros
2019-10-16 4:32 ` Pawel Laszczak
2019-10-16 9:20 ` Roger Quadros
2019-10-16 9:38 ` Pawel Laszczak
2019-10-16 9:54 ` Roger Quadros
2019-10-07 12:16 ` [PATCH 2/2] usb: cdns3: gadget: Fix full-speed mode Roger Quadros
2019-10-08 8:07 ` Peter Chen
2019-10-16 4:35 ` Pawel Laszczak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB470974072BDED3F032E35F80DD920@BYAPR07MB4709.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).