From: Andrey Konovalov <andreyknvl@google.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
USB list <linux-usb@vger.kernel.org>,
linux-media@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Mike Isely <isely@pobox.com>, LKML <linux-kernel@vger.kernel.org>,
syzbot <syzbot+af8f8d2ac0d39b0ed3a0@syzkaller.appspotmail.com>,
syzbot <syzbot+170a86bf206dd2c6217e@syzkaller.appspotmail.com>
Subject: Re: [PATCH] media: pvrusb2: use a different format for warnings
Date: Wed, 19 Jun 2019 17:24:38 +0200 [thread overview]
Message-ID: <CAAeHK+z_f5ugKEpKmfi3qqYE3_OZcTzmZYJaPn2c=hUK64VyJw@mail.gmail.com> (raw)
In-Reply-To: <20190619114458.52474694@coco.lan>
On Wed, Jun 19, 2019 at 4:45 PM Mauro Carvalho Chehab
<mchehab@kernel.org> wrote:
>
> Em Wed, 19 Jun 2019 16:30:01 +0200
> Andrey Konovalov <andreyknvl@google.com> escreveu:
>
> > On Thu, May 2, 2019 at 6:39 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Thu, May 02, 2019 at 06:09:26PM +0200, Andrey Konovalov wrote:
> > > > When the pvrusb2 driver detects that there's something wrong with the
> > > > device, it prints a warning message. Right now those message are
> > > > printed in two different formats:
> > > >
> > > > 1. ***WARNING*** message here
> > > > 2. WARNING: message here
> > > >
> > > > There's an issue with the second format. Syzkaller recognizes it as a
> > > > message produced by a WARN_ON(), which is used to indicate a bug in the
> > > > kernel. However pvrusb2 prints those warnings to indicate an issue with
> > > > the device, not the bug in the kernel.
> > > >
> > > > This patch changes the pvrusb2 driver to consistently use the first
> > > > warning message format. This will unblock syzkaller testing of this
> > > > driver.
> > > >
> > > > Reported-by: syzbot+af8f8d2ac0d39b0ed3a0@syzkaller.appspotmail.com
> > > > Reported-by: syzbot+170a86bf206dd2c6217e@syzkaller.appspotmail.com
> > > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> > >
> > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > I don't think I see this patch picked up anywhere. Should this fix go
> > through the USB or some media tree?
>
> Media drivers go via the media tree. You should notice that we are
> currently receiving around 100 patches per week there. It may take
> some time for people to review, but the patches are queued at
> patchwork, so sooner or later someone will review and apply, if nobody
> did it already:
>
> https://patchwork.linuxtv.org/project/linux-media/list/
>
> That's said, I'm not seeing this patch there:
>
> https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=pvrusb2&archive=&delegate=
>
> It sounds that, for whatever reason, the patch never arrived
> patchwork. Please re-submit it and check if media patchwork got it.
OK, done!
>
> If not, perhaps you just found a bug with patchwork 2.1 :-)
> (we upgraded from version 1.0 to 2.1 at the beginning of this
> month)
> Thanks,
> Mauro
prev parent reply other threads:[~2019-06-19 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 16:09 media: pvrusb2: use a different format for warnings Andrey Konovalov
2019-05-02 16:09 ` [PATCH] " Andrey Konovalov
2019-05-02 16:39 ` Greg Kroah-Hartman
2019-05-02 16:39 ` [PATCH] " Greg Kroah-Hartman
2019-06-19 14:30 ` Andrey Konovalov
2019-06-19 14:31 ` Andrey Konovalov
2019-06-19 14:44 ` Mauro Carvalho Chehab
2019-06-19 15:24 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeHK+z_f5ugKEpKmfi3qqYE3_OZcTzmZYJaPn2c=hUK64VyJw@mail.gmail.com' \
--to=andreyknvl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=isely@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+170a86bf206dd2c6217e@syzkaller.appspotmail.com \
--cc=syzbot+af8f8d2ac0d39b0ed3a0@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).