From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA1E0C10F14 for ; Tue, 15 Oct 2019 07:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C16D4217F9 for ; Tue, 15 Oct 2019 07:03:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TL+mG/A5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbfJOHD6 (ORCPT ); Tue, 15 Oct 2019 03:03:58 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43569 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbfJOHD5 (ORCPT ); Tue, 15 Oct 2019 03:03:57 -0400 Received: by mail-wr1-f65.google.com with SMTP id j18so22359622wrq.10 for ; Tue, 15 Oct 2019 00:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GHtFroTnmdsw/Ufdcr+oeGxBq/Br2emxbnTYV8HYTnw=; b=TL+mG/A5+Efmzbs0sdeqxBrMYlFpc2FrEEyfL35EFopAe+HsGZuSQJJOqZQFnTxLGk pXbcVtmRsFkkyzP/COnHyIpnMkaRZKdDE9YFzfjkak0a/3xf2LPASERjCd8qr95IHRop u3qrvdTDtspEI0NvFxBgbf1InlzLmWjVrH0eY7fH/BbUst9CyqS796cH7dD04UAF3fBs UOLUKY0DgE+awjrgKhTZml/iGB6Mmw9IF0FiORJ4TRf01y0n0aCHK+VQHtGMjbUWIOvR uXpTELzC7bA9CWJQ5mQCCcv0n723sA14uWqPiJBZSc7hkKmm/aRik47imHkpydcfVIQH LKRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GHtFroTnmdsw/Ufdcr+oeGxBq/Br2emxbnTYV8HYTnw=; b=UHvhbrA1YuGKeYftsEQzqvYaibWu/E+9hzcGPg9bAHxlgMH8M1MWpZKyrkcpqFo1el cKRkaF0kmS29XrmW75eFEJsY74B8Rh8lTmH1d61wBLAMfFZHh5BDIMS4PXGz9pfB6B4l MNzc9xgA4KDSClLWuNLB07b4+puOW0CMkgn/xuVbV+NeTP2buDwTOsuzu6605T/P/KWq KmjtFuBFNVEyEkHEVKNeJvSWXKikIP2UTthoOQpN/suiL7ZEArcaUlwoRvUzDvXYTz34 rtKuWQ82sflRy/0YeI2OobeqX3Co0+/kXtsDL0uKbKTZ/0M+gHPabvQKx9xla0iCcNQe YcjA== X-Gm-Message-State: APjAAAWBLs4L0bfrQHKB6C2+vSml6lZ2UQp+Jx0R9VJerh/TmWgOEwpN dJhDuUh5oCI1th8pjEJpaYXHQXOAHV1B7rqMcD0TTQ== X-Google-Smtp-Source: APXvYqyKestQtzWxynMKapAwLdcXnenRLDrzlPOr7NMxNHh1aAGyDLQQ27NbkRbsM8xOclShSRlCeUCU8nceBe/WLeQ= X-Received: by 2002:adf:f983:: with SMTP id f3mr28670813wrr.169.1571123035492; Tue, 15 Oct 2019 00:03:55 -0700 (PDT) MIME-Version: 1.0 References: <20191002231617.3670-1-john.stultz@linaro.org> <20191002231617.3670-3-john.stultz@linaro.org> <20191003112618.GA2420393@kroah.com> <9cfccb6a-fba1-61a3-3eb6-3009c2f5e747@redhat.com> In-Reply-To: From: John Stultz Date: Tue, 15 Oct 2019 00:03:43 -0700 Message-ID: Subject: Re: [RFC][PATCH 2/3] usb: roles: Add usb role switch notifier. To: Hans de Goede Cc: Greg Kroah-Hartman , lkml , Yu Chen , Rob Herring , Mark Rutland , Heikki Krogerus , Suzuki K Poulose , Chunfeng Yun , Felipe Balbi , Andy Shevchenko , Jun Li , Valentin Schneider , Linux USB List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sun, Oct 6, 2019 at 8:22 AM Hans de Goede wrote: > > Anyways back the code to add a usb role switch notifier. I do > not think that this is a good idea, this is making "core" changes > to deal with a special case. If you are going to use a notfier for > this then IMHO the notifier should be part of the hikey960 usb role > swtich driver and not be in the usb-role-switch class code, since > this is very much a device specific hack. Ok, that sounds fair. I still need to find some way to hook into the role-switch path between the tcpm and the dwc3 in order to switch to the hub, but I guess I can try to add a hook somewhere in the dwc3 code itself. I'll dig on this a bit. thanks -john