From: Grant Grundler <grundler@chromium.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Hayes Wang <hayeswang@realtek.com>,
Grant Grundler <grundler@chromium.org>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
linux-usb@vger.kernel.org, Roland Dreier <roland@kernel.org>
Subject: Re: [PATCHv2 2/3] usbnet: add method for reporting speed without MDIO
Date: Fri, 22 Jan 2021 02:56:57 +0000 [thread overview]
Message-ID: <CANEJEGteGiFRySiSV8gMkiCN8nFGX7N+zL9_udRJzG-knng71Q@mail.gmail.com> (raw)
In-Reply-To: <20210121125731.19425-3-oneukum@suse.com>
On Thu, Jan 21, 2021 at 12:57 PM Oliver Neukum <oneukum@suse.com> wrote:
>
> The old method for reporting network speed upwards
> assumed that a device uses MDIO and uses the generic phy
> functions based on that.
> Add a a primitive internal version not making the assumption
> reporting back directly what the status operations record.
>
> v2: adjusted to recent changes
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Tested-by: Roland Dreier <roland@kernel.org>
> ---
> drivers/net/usb/usbnet.c | 23 +++++++++++++++++++++++
> include/linux/usb/usbnet.h | 4 ++++
> 2 files changed, 27 insertions(+)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index e2ca88259b05..6f8fcc276ca7 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -961,6 +961,27 @@ int usbnet_get_link_ksettings_mdio(struct net_device *net,
> }
> EXPORT_SYMBOL_GPL(usbnet_get_link_ksettings_mdio);
>
> +int usbnet_get_link_ksettings_internal(struct net_device *net,
> + struct ethtool_link_ksettings *cmd)
> +{
> + struct usbnet *dev = netdev_priv(net);
> +
> + /* the assumption that speed is equal on tx and rx
> + * is deeply engrained into the networking layer.
Another nit: s/engrained/ingrained
Also, the word "symmetric" is more commonly used to describe when RX
speed == TX speed (vs "equal").
cheers,
grant
> + * For wireless stuff it is not true.
> + * We assume that rxspeed matters more.
> + */
> + if (dev->rxspeed != SPEED_UNKNOWN)
> + cmd->base.speed = dev->rxspeed / 1000000;
> + else if (dev->txspeed != SPEED_UNKNOWN)
> + cmd->base.speed = dev->txspeed / 1000000;
> + else
> + cmd->base.speed = SPEED_UNKNOWN;
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(usbnet_get_link_ksettings_internal);
> +
> int usbnet_set_link_ksettings_mdio(struct net_device *net,
> const struct ethtool_link_ksettings *cmd)
> {
> @@ -1664,6 +1685,8 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
> dev->intf = udev;
> dev->driver_info = info;
> dev->driver_name = name;
> + dev->rxspeed = SPEED_UNKNOWN; /* unknown or handled by MII */
> + dev->txspeed = SPEED_UNKNOWN;
>
> net->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);
> if (!net->tstats)
> diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h
> index fd65b7a5ee15..a91c6defb104 100644
> --- a/include/linux/usb/usbnet.h
> +++ b/include/linux/usb/usbnet.h
> @@ -53,6 +53,8 @@ struct usbnet {
> u32 hard_mtu; /* count any extra framing */
> size_t rx_urb_size; /* size for rx urbs */
> struct mii_if_info mii;
> + long rxspeed; /* if MII is not used */
> + long txspeed; /* if MII is not used */
>
> /* various kinds of pending driver work */
> struct sk_buff_head rxq;
> @@ -269,6 +271,8 @@ extern void usbnet_purge_paused_rxq(struct usbnet *);
>
> extern int usbnet_get_link_ksettings_mdio(struct net_device *net,
> struct ethtool_link_ksettings *cmd);
> +extern int usbnet_get_link_ksettings_internal(struct net_device *net,
> + struct ethtool_link_ksettings *cmd);
> extern int usbnet_set_link_ksettings_mdio(struct net_device *net,
> const struct ethtool_link_ksettings *cmd);
> extern u32 usbnet_get_link(struct net_device *net);
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-01-22 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 12:57 [PATCHv2 0/3] usbnet: speed reporting for devices without MDIO Oliver Neukum
2021-01-21 12:57 ` [PATCHv2 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings Oliver Neukum
2021-01-22 1:10 ` Andrew Lunn
2021-01-26 9:42 ` Oliver Neukum
2021-01-26 13:34 ` Andrew Lunn
2021-01-21 12:57 ` [PATCHv2 2/3] usbnet: add method for reporting speed without MDIO Oliver Neukum
2021-01-22 1:35 ` Grant Grundler
2021-01-22 2:56 ` Grant Grundler [this message]
2021-01-21 12:57 ` [PATCHv2 3/3] CDC-NCM: record speed in status method Oliver Neukum
2021-01-22 3:02 ` Grant Grundler
2021-01-22 1:29 ` [PATCHv2 0/3] usbnet: speed reporting for devices without MDIO Andrew Lunn
2021-01-22 2:10 ` Grant Grundler
2021-02-09 23:47 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANEJEGteGiFRySiSV8gMkiCN8nFGX7N+zL9_udRJzG-knng71Q@mail.gmail.com \
--to=grundler@chromium.org \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).