From: Pho Tran <Pho.Tran@silabs.com>
To: 'Greg KH' <gregkh@linuxfoundation.org>,
'Pho Tran' <photranvan0712@gmail.com>
Cc: "'johan@kernel.org'" <johan@kernel.org>,
"'linux-usb@vger.kernel.org'" <linux-usb@vger.kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
Hung Nguyen <Hung.Nguyen@silabs.com>,
Tung Pham <Tung.Pham@silabs.com>,
'Kernel test robot' <lkp@intel.com>
Subject: RE: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108
Date: Tue, 6 Apr 2021 08:17:42 +0000 [thread overview]
Message-ID: <DM6PR11MB44414602F10C6C991A65D48CE3769@DM6PR11MB4441.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YGvuQlxyorJt+ErG@kroah.com>
Hi Greg!
I am grateful for your promptly reply!
Yesterday, I got the response from the kernel test robot with this message:
" If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>".
It's a reason why I added "Reported-by: kernel test robot <lkp@intel.com>"
to my new Patch.
Could you tell me what I need to do in the next step to submit this patch to the kernel mainline?
Once again, Thank you a lot!
-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>
Sent: Tuesday, April 6, 2021 12:15 PM
To: Pho Tran <photranvan0712@gmail.com>
Cc: johan@kernel.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Hung Nguyen <Hung.Nguyen@silabs.com>; Tung Pham <Tung.Pham@silabs.com>; Pho Tran <Pho.Tran@silabs.com>; Kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
On Tue, Apr 06, 2021 at 11:02:38AM +0700, Pho Tran wrote:
> From: Pho Tran <pho.tran@silabs.com>
>
> Similar to other CP210x devices, GPIO interfaces (gpiochip) should be
> supported for CP2108.
>
> CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared
> to all of those interfaces. So, just need to initialize GPIOs of
> CP2108 with only one interface (I use interface 0). It means just only
> 1 gpiochip device file will be created for CP2108.
>
> CP2108 has 16 GPIOs, So data types of several variables need to be is
> u16 instead of u8(in struct cp210x_serial_private). This doesn't
> affect other CP210x devices.
>
> Because CP2108 has 16 GPIO pins, the parameter passed by cp210x
> functions will be different from other CP210x devices. So need to
> check part number of the device to use correct data format before
> sending commands to devices.
>
> Like CP2104, CP2108 have GPIO pins with configurable options.
> Therefore, should be mask all pins which are not in GPIO mode in
> cp2108_gpio_init() function.
>
> Fix build test WARNING reported by kernel test robot.
>
> Reported-by: Kernel test robot <lkp@intel.com>
The kernel test robot did not report this needed support :(
next prev parent reply other threads:[~2021-04-06 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 4:02 [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108 Pho Tran
2021-04-06 5:14 ` Greg KH
2021-04-06 8:17 ` Pho Tran [this message]
2021-04-06 9:11 ` 'Greg KH'
2021-04-06 9:25 ` Pho Tran
2021-04-06 9:34 ` 'Greg KH'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB44414602F10C6C991A65D48CE3769@DM6PR11MB4441.namprd11.prod.outlook.com \
--to=pho.tran@silabs.com \
--cc=Hung.Nguyen@silabs.com \
--cc=Tung.Pham@silabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=photranvan0712@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).