From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"usb-storage@lists.one-eyed-alien.net"
<usb-storage@lists.one-eyed-alien.net>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] usb-storage: Add a limitation for blk_queue_max_hw_sectors()
Date: Thu, 13 Jun 2019 09:03:43 +0000 [thread overview]
Message-ID: <OSAPR01MB308976F808F8588C4B49BF54D8EF0@OSAPR01MB3089.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190613085121.GA13442@lst.de>
Hi Christoph,
> From: Christoph Hellwig, Sent: Thursday, June 13, 2019 5:51 PM
>
> On Thu, Jun 13, 2019 at 08:46:00AM +0000, Yoshihiro Shimoda wrote:
> > I believe this patch I sent has already covered it. What do you think?
> >
> > For examples (all value units are "sectors"):
> > default mapping size max_sectors
> > case 1 240 MAX 2048 --> we use 2048
> > case 2 240 512 2048 --> we use 512
> > case 3 240 128 2048 --> we use 128
> > case 4 240 128 64 --> we use 64
>
> Yes, I guess your version is fine after all:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thank you for your review!
> although I think it might be simpler to just read the value back
> from the queue in the end.
Ah, now I understand why you suggest it.
I agree with you. This patch changed 23 lines. But, it will change a few lines only.
So, I'll make such a patch.
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2019-06-13 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 4:35 [PATCH] usb-storage: Add a limitation for blk_queue_max_hw_sectors() Yoshihiro Shimoda
2019-06-13 7:33 ` Christoph Hellwig
2019-06-13 8:46 ` Yoshihiro Shimoda
2019-06-13 8:51 ` Christoph Hellwig
2019-06-13 9:03 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB308976F808F8588C4B49BF54D8EF0@OSAPR01MB3089.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).