From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: "balbi@kernel.org" <balbi@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "wsa@sang-engineering.com" <wsa@sang-engineering.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH/RESEND] usb: renesas_usbhs: Fix superfluous irqs happen after usb_pkt_pop()
Date: Wed, 14 Jul 2021 08:53:16 +0000 [thread overview]
Message-ID: <TY2PR01MB3692BEA8919501DCFF1BD4ADD8139@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210624122039.596528-1-yoshihiro.shimoda.uh@renesas.com>
Hi,
> From: Yoshihiro Shimoda , Sent: Thursday, June 24, 2021 9:21 PM
>
> This driver has a potential issue which this driver is possible to
> cause superfluous irqs after usb_pkt_pop() is called. So, after
> the commit 3af32605289e ("usb: renesas_usbhs: fix error return
> code of usbhsf_pkt_handler()") had been applied, we could observe
> the following error happened when we used g_audio.
>
> renesas_usbhs e6590000.usb: irq_ready run_error 1 : -22
>
> To fix the issue, disable the tx or rx interrupt in usb_pkt_pop().
>
> Fixes: 2743e7f90dc0 ("usb: renesas_usbhs: fix the usb_pkt_pop()")
> Cc: <stable@vger.kernel.org> # v4.4+
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> I'm sorry for causing a trouble before [1], so I resend a suitable patch.
> [1]
> https://lore.kernel.org/linux-renesas-soc/TY2PR01MB3692555C6EAC8F02BC8B3D63D8329@TY2PR01MB3692.jpnprd01.prod.outlook.com/
I'm afraid, but would you review this patch?
I confirmed this patch can be applied into v5.14-rc1.
Or, should I resend this patch?
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2021-07-14 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 12:20 [PATCH/RESEND] usb: renesas_usbhs: Fix superfluous irqs happen after usb_pkt_pop() Yoshihiro Shimoda
2021-07-14 8:53 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY2PR01MB3692BEA8919501DCFF1BD4ADD8139@TY2PR01MB3692.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wsa@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).