From: Peter Chen <peter.chen@nxp.com>
To: Henry Lin <henryl@nvidia.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Romain Izard <romain.izard.pro@gmail.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
EJ Hsu <ejh@nvidia.com>
Subject: RE: [PATCH] usb: gadget: f_ncm: fix wrong usb_ep
Date: Thu, 28 Nov 2019 09:28:32 +0000 [thread overview]
Message-ID: <VI1PR04MB53277F89D11A5EE67F95861C8B470@VI1PR04MB5327.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <MN2PR12MB3389A88286B9A8348596F947AC470@MN2PR12MB3389.namprd12.prod.outlook.com>
> >> >It should set all desc to NULL at related function ->disable.
> >>
> >> For ECM case, if ecm_set_alt() gets called with alt == 0, in_ep->desc
> >> and out_ep-
> >> >desc will be set up. But these two ep will not be enabled as
> >> >gether_connect() is not
> >> executed. During disconnect from the host, ecm_disable() gets called
> >> with ep disabled. In this case, gether_disconnect() will not get called to set desc
> to NULL.
>
> >Would you please share your test case? I use Linux host, and the host
> >will always set alt for 1, and doesn't have this issue.
> Using Windows host (without any proprietary NCM/ECM driver installed) can
> reproduce set alt to 0. We just used Win10 to confirm this.
Ok, feel free to submit a patch to fix it.
Peter
prev parent reply other threads:[~2019-11-28 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 4:18 [PATCH] usb: gadget: f_ncm: fix wrong usb_ep Henry Lin
2019-11-25 4:20 ` Peter Chen
2019-11-26 7:26 ` Henry Lin
2019-11-26 7:55 ` Peter Chen
2019-11-26 10:03 ` Henry Lin
2019-11-27 1:54 ` Peter Chen
2019-11-28 9:21 ` Henry Lin
2019-11-28 9:28 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB53277F89D11A5EE67F95861C8B470@VI1PR04MB5327.eurprd04.prod.outlook.com \
--to=peter.chen@nxp.com \
--cc=balbi@kernel.org \
--cc=ejh@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=henryl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=romain.izard.pro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).