From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E2AC433DB for ; Tue, 26 Jan 2021 14:21:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D74E8206CA for ; Tue, 26 Jan 2021 14:21:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405900AbhAZOUh (ORCPT ); Tue, 26 Jan 2021 09:20:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:53882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405882AbhAZOUK (ORCPT ); Tue, 26 Jan 2021 09:20:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B0B2206CA; Tue, 26 Jan 2021 14:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611670769; bh=b+c5T4n9jRaht6O5yOfV/FqKLavfrxzcJDIn1MjA930=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2lBpWeSC29oVeuZA6cKzBaKlSzU0oEFOh2eh/D3NFKYLCkzk4YH+deCKOwPHnwzfE B75IGiTpdEHsT2OvpqsSPcj0p1TrDSTL7t5eAmB8JJ29CzJ3wAUlEpg4aL9dbwVkaf qBznZa5/CL4hGZXjIZlnS586fJo49ogasQOXQKrk= Date: Tue, 26 Jan 2021 15:19:27 +0100 From: Greg KH To: Mathias Nyman Cc: Howard Yen , Mathias Nyman , robh+dt@kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] add xhci hooks for USB offload Message-ID: References: <20210119101044.1637023-1-howardyen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Jan 22, 2021 at 05:32:58PM +0200, Mathias Nyman wrote: > On 20.1.2021 12.04, Howard Yen wrote: > > On Tue, Jan 19, 2021 at 8:47 PM Mathias Nyman wrote: > >> > >> On 19.1.2021 12.10, Howard Yen wrote: > >>> To let the xhci driver support USB offload, add hooks for vendor to have > >>> customized behavior for the initialization, memory allocation, irq work, and > >>> device context synchronization. Detail is in each patch commit message. > >> > >> Is this related to the usb audio sideband capability that was added to the xHCI specification? > >> If yes, then we should probably implement the generic parts first, and then add > >> the vendor specific hooks. > >> > >> -Mathias > >> > >> > > > > This is for offloading, no matter what type of offloading. > > I made the hooks generically and can be used for usb audio on the xhci > > which is not including the usb audio sideband capability. > > > > Ok, before adding hooks like this I think we need to see how they are used. > Do you have the rest of the patches that go on top of this series? > > Maybe it could make sense to use overrides for the functions in struct hc_driver > instead in some cases? There is support for that already. What overrides could be done for these changes? At first glance that would seem to require a lot of duplicated code in whatever override happens to be needed. thanks, greg k-h