From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Andy Gross <agross@kernel.org>, Felipe Balbi <balbi@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Vladimir Zapolskiy <vz@mleia.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Vineet Gupta <vgupta@synopsys.com>,
Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-usb@vger.kernel.org, Serge Semin <fancer.lancer@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v8 6/7] usb: dwc3: qcom: Detect DWC3 DT-nodes using compatible string
Date: Fri, 9 Apr 2021 09:05:39 -0500 [thread overview]
Message-ID: <YHBfM1/ag5fR3Oyi@builder.lan> (raw)
In-Reply-To: <20210409113029.7144-7-Sergey.Semin@baikalelectronics.ru>
On Fri 09 Apr 06:30 CDT 2021, Serge Semin wrote:
> In accordance with the USB HCD/DRD schema all the USB controllers are
> supposed to have DT-nodes named with prefix "^usb(@.*)?". Since the
> existing DT-nodes will be renamed in a subsequent patch let's fix the DWC3
> Qcom-specific code to detect the DWC3 sub-node just by checking its
> compatible string to match the "snps,dwc3". The semantic of the code
> won't change seeing all the DWC USB3 nodes are supposed to have the
> compatible property with any of those strings set.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v7:
> - Replace "of_get_child_by_name(np, "usb") ?: of_get_child_by_name(np, "dwc3");"
> pattern with using of_get_compatible_child() method.
> - Discard Bjorn Andersson Reviewed-by tag since the patch content
> has been changed.
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index fcaf04483ad0..617a1be88371 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -644,7 +644,7 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> int ret;
>
> - dwc3_np = of_get_child_by_name(np, "dwc3");
> + dwc3_np = of_get_compatible_child(np, "snps,dwc3");
> if (!dwc3_np) {
> dev_err(dev, "failed to find dwc3 core child\n");
> return -ENODEV;
> --
> 2.30.1
>
next prev parent reply other threads:[~2021-04-09 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 11:30 [PATCH RESEND v8 0/7] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
2021-04-09 11:30 ` [PATCH RESEND v8 1/7] arc: dts: Harmonize EHCI/OHCI DT " Serge Semin
2021-04-09 11:30 ` [PATCH RESEND v8 2/7] arm: dts: lpc18xx: " Serge Semin
2021-04-09 11:30 ` [PATCH RESEND v8 3/7] powerpc: dts: akebono: " Serge Semin
2021-04-09 11:30 ` [PATCH RESEND v8 4/7] arm: dts: stih407-family: Harmonize DWC USB3 " Serge Semin
2021-04-09 11:30 ` [PATCH RESEND v8 5/7] arm64: dts: apm: " Serge Semin
2021-04-09 11:30 ` [PATCH RESEND v8 6/7] usb: dwc3: qcom: Detect DWC3 DT-nodes using compatible string Serge Semin
2021-04-09 14:05 ` Bjorn Andersson [this message]
2021-04-09 11:30 ` [PATCH RESEND v8 7/7] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name Serge Semin
2021-04-09 15:39 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHBfM1/ag5fR3Oyi@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=abrodkin@synopsys.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=robh+dt@kernel.org \
--cc=vgupta@synopsys.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).