Re: Lacie Rugged USB3-FW does not work with UAS

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Jul 19, 2021 at 06:10:10PM +0200, Julian Sikorski wrote:
> W dniu 19.07.2021 o 14:47, Oliver Neukum pisze:
> > 
> > > Hi all,
> > > 
> > > apologies for necro-ing this thread. I have just tried this drive with
> > > my new laptop (Asus ZenBook UM425IA) and the same quirk was needed to
> > > get the drive to work:
> > > options usb-storage quirks=059f:1061:u
> > > 
> > > Should we still try to get uas working with this drive or should I
> > > send a patch hardcoding a quirk? I am on 5.13.2-300.fc34.x86_64 kernel
> > > now. Thanks for the feedback in advance.
> > > 
> > 
> > Hi,
> > 
> > 
> > sometimes we must give up. This thing is too elusive. Please send a
> > patch with a quirk.
> > 
> >      Regards
> > 
> >          Oliver
> > 
> > 
> 
> Hi,
> 
> thanks for confirming. Patch is attached, it appears to be working correctly
> when applied against 5.13.3. Please let me know if changes are required.
> 
> Best regards,
> Julian

> >From 01057f40aaf0036271dc401add9310dc63bfbcc1 Mon Sep 17 00:00:00 2001
> From: Julian Sikorski <belegdol+github@gmail.com>
> Date: Mon, 19 Jul 2021 17:27:16 +0200
> Subject: [PATCH] Add LaCie Rugged USB3-FW to IGNORE_UAS
> 
> LaCie Rugged USB3-FW appears to be incompatible with UAS. It generates
> errors like:
> [ 1151.582598] sd 14:0:0:0: tag#16 uas_eh_abort_handler 0 uas-tag 1 inflight: IN
> [ 1151.582602] sd 14:0:0:0: tag#16 CDB: Report supported operation codes a3 0c 01 12 00 00 00 00 02 00 00 00
> [ 1151.588594] scsi host14: uas_eh_device_reset_handler start
> [ 1151.710482] usb 2-4: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd
> [ 1151.741398] scsi host14: uas_eh_device_reset_handler success
> [ 1181.785534] scsi host14: uas_eh_device_reset_handler start
> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index f9677a5ec31b..c35a6db993f1 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -45,6 +45,13 @@ UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
>  
> +/* Reported-by: Julian Sikorski <belegdol@gmail.com> */
> +UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
> +		"LaCie",
> +		"Rugged USB3-FW",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_IGNORE_UAS),
> +
>  /*
>   * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
>   * commands in UAS mode.  Observed with the 1.28 firmware; are there others?
> -- 
> 2.31.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot