From: Johan Hovold <johan@kernel.org>
To: Himadri Pandya <himadrispandya@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] USB: serial: use wrappers for usb_control_msg()
Date: Tue, 21 Sep 2021 13:10:05 +0200 [thread overview]
Message-ID: <YUm9jX6nG+n2q3SV@hovoldconsulting.com> (raw)
In-Reply-To: <20210801203122.3515-1-himadrispandya@gmail.com>
On Mon, Aug 02, 2021 at 02:01:16AM +0530, Himadri Pandya wrote:
> There are many usages of usb_control_msg() that can use the new wrapper
> functions usb_contro_msg_send() & usb_control_msg_recv() for better
> error checks on short reads and writes.
As I said before, there no need to worry about short writes as that will
always return an error. So this description (and some of the commit
messages) needs a bit of work.
> They can also be used to avoid
> allocating redundant dma buffers that are generally required to use
> usb_control_msg().
The DMA buffers are anything but redundant; they are required. But the
wrappers can be used to not have to manage the dma buffers explicitly.
> Hence use them whenever possible and avoid using
> usb_control_msg() directly.
>
> Changes in v2:
> - Drop unnecessary use of wrappers
> - Drop unrelated style changes
>
> Additional Info:
> - This is a super late follow-up on v1 that was submitted a while
> ago(my sincere apologies). (All patches are rebased and
> compile tested.)
> - v1 patches: https://lkml.org/lkml/2020/11/4/40
> - Patches that introduced the wrapper functions:
> https://lkml.org/lkml/2020/9/14/859
No worries, I'll go review the patches now.
Johan
prev parent reply other threads:[~2021-09-21 11:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 20:31 [PATCH v2 0/6] USB: serial: use wrappers for usb_control_msg() Himadri Pandya
2021-08-01 20:31 ` [PATCH v2 1/6] USB: serial: ch314: use usb_control_msg_recv() and usb_control_msg_send() Himadri Pandya
2021-09-21 11:26 ` Johan Hovold
2021-08-01 20:31 ` [PATCH v2 2/6] USB: serial: cp210x: " Himadri Pandya
2021-09-21 11:34 ` Johan Hovold
2021-08-01 20:31 ` [PATCH v2 3/6] USB: serial: f81232: " Himadri Pandya
2021-09-21 12:06 ` Johan Hovold
2021-08-01 20:31 ` [PATCH v2 4/6] USB: serial: ftdi_sio: use usb_control_msg_recv() Himadri Pandya
2021-09-21 12:17 ` Johan Hovold
2021-08-01 20:31 ` [PATCH v2 5/6] USB: serial: keyspan_pda: " Himadri Pandya
2021-09-21 12:27 ` Johan Hovold
2021-08-01 20:31 ` [PATCH v2 6/6] USB: serial: kl5kusb105: use usb_control_msg_recv() and usb_control_msg_send() Himadri Pandya
2021-09-21 12:41 ` Johan Hovold
2021-09-26 13:00 ` Himadri Pandya
2021-09-21 11:10 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUm9jX6nG+n2q3SV@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=himadrispandya@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).