From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sean Young <sean@mess.org>,
Alan Stern <stern@rowland.harvard.edu>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jarod Wilson <jarod@redhat.com>,
syzbot <syzbot+c558267ad910fc494497@syzkaller.appspotmail.com>,
andreyknvl@google.com, linux-media@vger.kernel.org,
linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH v2 (resend)] media: imon: reorganize serialization
Date: Mon, 2 May 2022 22:04:22 +0900 [thread overview]
Message-ID: <ae9de04c-3d00-1e5e-cd45-bb3baf4f6184@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <Ym/UQpEV46W6frqH@kroah.com>
On 2022/05/02 21:53, Greg KH wrote:
>> @@ -153,6 +153,24 @@ struct imon_context {
>> const struct imon_usb_dev_descr *dev_descr;
>> /* device description with key */
>> /* table for front panels */
>> + /*
>> + * Fields for deferring free_imon_context().
>> + *
>> + * Since reference to "struct imon_context" is stored into
>> + * "struct file_operations"->private_data, we need to remember
>> + * how many file descriptors might access this "struct imon_context".
>> + */
>> + refcount_t users;
>
> Are you sure this is going to work properly?
>
> How do you handle userspace passing around file descriptors to other
> processes?
>
> You really should not ever have to count this.
Passing around file descriptors results in nothing but delay of freeing memory.
Is this so fatal problem?
static void free_imon_context(struct imon_context *ictx)
{
struct device *dev = ictx->dev;
usb_free_urb(ictx->tx_urb);
usb_free_urb(ictx->rx_urb_intf0);
usb_free_urb(ictx->rx_urb_intf1);
kfree(ictx);
dev_dbg(dev, "%s: iMON context freed\n", __func__);
}
If this is so fatal, can we call usb_free_urb() upon imon_disconnect() ?
next prev parent reply other threads:[~2022-05-02 13:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 13:18 possible deadlock in display_open syzbot
2022-04-25 5:29 ` Tetsuo Handa
2022-04-25 9:20 ` Sean Young
2022-04-25 11:14 ` Tetsuo Handa
2022-04-25 11:56 ` Sean Young
2022-04-25 16:01 ` Alan Stern
2022-04-25 16:21 ` Sean Young
2022-04-26 0:54 ` [PATCH] media: imon: remove redundant serialization Tetsuo Handa
2022-04-26 7:57 ` Sean Young
2022-04-26 10:32 ` [PATCH v2] media: imon: reorganize serialization Tetsuo Handa
2022-05-02 3:49 ` [PATCH v2 (resend)] " Tetsuo Handa
2022-05-02 9:39 ` Sean Young
2022-05-02 10:26 ` Tetsuo Handa
2022-05-02 10:40 ` Tetsuo Handa
2022-05-02 10:46 ` Oliver Neukum
2022-05-02 11:05 ` Tetsuo Handa
2022-05-03 7:41 ` Oliver Neukum
2022-05-02 12:53 ` Greg KH
2022-05-02 13:04 ` Tetsuo Handa [this message]
2022-05-02 13:06 ` Greg KH
2022-05-02 13:40 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9de04c-3d00-1e5e-cd45-bb3baf4f6184@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=andreyknvl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+c558267ad910fc494497@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).