From: Roger Quadros <rogerq@ti.com>
To: Bin Liu <b-liu@ti.com>, <linux-usb@vger.kernel.org>
Cc: Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH] usb: dwc3: turn off VBUS when leaving host mode
Date: Thu, 14 Nov 2019 10:48:36 +0200 [thread overview]
Message-ID: <b354e1bf-6824-ccb1-9b8b-7b54b0e8fc2b@ti.com> (raw)
In-Reply-To: <20191113141521.1696-1-b-liu@ti.com>
Bin,
On 13/11/2019 16:15, Bin Liu wrote:
> VBUS should be turned off when leaving the host mode.
> Set GCTL_PRTCAP to device mode in teardown to de-assert DRVVBUS pin to
> turn off VBUS power.
Doesn't DRVVBUS pin de-assert when root hub driver turns off port power?
Which should happen when XHCI host driver is unregistered as part of
dwc3_host_exit()?
cheers,
-roger
>
> Fixes: 5f94adfeed97 ("usb: dwc3: core: refactor mode initialization to its own function")
> Signed-off-by: Bin Liu <b-liu@ti.com>
> ---
> drivers/usb/dwc3/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 97d6ae3c4df2..76ac9cd54e64 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1201,6 +1201,7 @@ static void dwc3_core_exit_mode(struct dwc3 *dwc)
> break;
> case USB_DR_MODE_HOST:
> dwc3_host_exit(dwc);
> + dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_DEVICE);
> break;
> case USB_DR_MODE_OTG:
> dwc3_drd_exit(dwc);
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-11-14 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 14:15 [PATCH] usb: dwc3: turn off VBUS when leaving host mode Bin Liu
2019-11-14 8:48 ` Roger Quadros [this message]
2019-11-14 14:16 ` Bin Liu
2019-11-18 7:07 ` Felipe Balbi
2019-11-18 9:51 ` Roger Quadros
2019-12-02 7:41 ` Felipe Balbi
2019-12-09 17:15 ` Bin Liu
2019-12-10 11:50 ` Felipe Balbi
2019-12-10 13:48 ` Bin Liu
2019-12-11 14:41 ` Felipe Balbi
2019-12-11 16:10 ` [PATCH v2] " Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b354e1bf-6824-ccb1-9b8b-7b54b0e8fc2b@ti.com \
--to=rogerq@ti.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).