From: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH v3 0/4] Add logic to consolidate TRBs for Synopsys xHC
Date: Mon, 8 Jun 2020 04:32:44 +0000 [thread overview]
Message-ID: <ba1eb639-7c58-c2b2-1bd9-dacec5d1092b@synopsys.com> (raw)
In-Reply-To: <cover.1590415123.git.joglekar@synopsys.com>
Hi Mathias,
Will this be added to your next branch ?
On 5/27/2020 4:10 PM, Tejas Joglekar wrote:
> The Synopsys xHC has an internal TRB cache of size TRB_CACHE_SIZE for
> each endpoint. The default value for TRB_CACHE_SIZE is 16 for SS and 8
> for HS. The controller loads and updates the TRB cache from the
> transfer ring in system memory whenever the driver issues a start
> transfer or update transfer command.
>
> For chained TRBs, the Synopsys xHC requires that the total amount of
> bytes for all TRBs loaded in the TRB cache be greater than or equal to
> 1 MPS. Or the chain ends within the TRB cache (with a last TRB).
>
> If this requirement is not met, the controller will not be able to
> send or receive a packet and it will hang causing a driver timeout and
> error.
>
> This patch set adds logic to the XHCI driver to detect and prevent this
> from happening along with the quirk to enable this logic for Synopsys
> HAPS platform.
>
> Based on Mathias's feedback on previous implementation where consolidation
> was done in TRB cache, with this patch series the implementation is done
> during mapping of the URB by consolidating the SG list into a temporary
> buffer if the SG list buffer sizes within TRB_CACHE_SIZE is less than MPS.
>
> Changes since v2:
> - Modified the xhci_unmap_temp_buffer function to unmap dma and clear
> the dma flag
> - Removed RFC tag
>
> Changes since v1:
> - Comments from Greg are addressed on [PATCH 4/4] and [PATCH 1/4]
> - Renamed the property and quirk as in other patches based on [PATCH 1/4]
>
> Tejas Joglekar (4):
> dt-bindings: usb: Add documentation for SG trb cache size quirk
> usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK
> usb: dwc3: Add device property sgl-trb-cache-size-quirk
> usb: xhci: Use temporary buffer to consolidate SG
>
> Documentation/devicetree/bindings/usb/dwc3.txt | 4 +
> Documentation/devicetree/bindings/usb/usb-xhci.txt | 3 +
> drivers/usb/dwc3/core.c | 2 +
> drivers/usb/dwc3/core.h | 2 +
> drivers/usb/dwc3/dwc3-haps.c | 1 +
> drivers/usb/dwc3/host.c | 6 +-
> drivers/usb/host/xhci-pci.c | 3 +
> drivers/usb/host/xhci-plat.c | 4 +
> drivers/usb/host/xhci-ring.c | 2 +-
> drivers/usb/host/xhci.c | 135 +++++++++++++++++++++
> drivers/usb/host/xhci.h | 5 +
> 11 files changed, 165 insertions(+), 2 deletions(-)
>
Thanks and Regards,
Tejas Joglekar
next prev parent reply other threads:[~2020-06-08 4:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:40 [PATCH v3 0/4] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2020-05-27 10:40 ` [PATCH v3 1/4] dt-bindings: usb: Add documentation for SG trb cache size quirk Tejas Joglekar
2020-05-29 18:05 ` Rob Herring
2020-05-27 10:41 ` [PATCH v3 2/4] usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK Tejas Joglekar
2020-05-27 10:41 ` [PATCH v3 3/4] usb: dwc3: Add device property sgl-trb-cache-size-quirk Tejas Joglekar
2020-07-06 5:07 ` Tejas Joglekar
2020-07-06 6:43 ` Felipe Balbi
2020-07-07 17:21 ` Tejas Joglekar
2020-07-12 13:45 ` Tejas Joglekar
2020-07-15 5:51 ` Tejas Joglekar
2020-07-21 9:47 ` Felipe Balbi
2020-07-21 16:57 ` Tejas Joglekar
2020-07-31 10:13 ` Tejas Joglekar
2020-08-04 0:44 ` Thinh Nguyen
2020-08-04 1:59 ` Jun Li
2020-05-27 10:42 ` [PATCH v3 4/4] usb: xhci: Use temporary buffer to consolidate SG Tejas Joglekar
2020-06-08 4:32 ` Tejas Joglekar [this message]
2020-06-09 8:57 ` [PATCH v3 0/4] Add logic to consolidate TRBs for Synopsys xHC Mathias Nyman
2020-06-11 18:07 ` Tejas Joglekar
2020-06-30 6:28 ` Tejas Joglekar
2020-07-23 10:35 ` Jun Li
2020-07-24 0:15 ` Tejas Joglekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba1eb639-7c58-c2b2-1bd9-dacec5d1092b@synopsys.com \
--to=tejas.joglekar@synopsys.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).