From: Guenter Roeck <linux@roeck-us.net>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Krzysztof Sobota <krzysztof.sobota@nokia.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Fix double-free in watchdog_cdev_register
Date: Sun, 23 Aug 2020 12:06:27 -0700 [thread overview]
Message-ID: <03f9c262-3174-21e4-2211-df9fb2097457@roeck-us.net> (raw)
In-Reply-To: <20200823071338.15209-1-dinghao.liu@zju.edu.cn>
On 8/23/20 12:13 AM, Dinghao Liu wrote:
> When misc_register() fails, wd_data will be released by the
> release callback function watchdog_core_data_release(), so
> we don't need to free it again. But when watchdog_kworker is
> NULL, we should free wd_data to prevent memleak.
>
> Fixes: cb36e29bb0e4b ("watchdog: initialize device before misc_register")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/watchdog/watchdog_dev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
> index 6798addabd5a..8ee78e26feb1 100644
> --- a/drivers/watchdog/watchdog_dev.c
> +++ b/drivers/watchdog/watchdog_dev.c
> @@ -994,8 +994,10 @@ static int watchdog_cdev_register(struct watchdog_device *wdd)
> wd_data->wdd = wdd;
> wdd->wd_data = wd_data;
>
> - if (IS_ERR_OR_NULL(watchdog_kworker))
> + if (IS_ERR_OR_NULL(watchdog_kworker)) {
> + kfree(wd_data);
This should be a separate patch, with
Fixes: 664a39236e718 ("watchdog: Introduce hardware maximum heartbeat in watchdog core")
> return -ENODEV;
> + }
>
> device_initialize(&wd_data->dev);
> wd_data->dev.devt = MKDEV(MAJOR(watchdog_devt), wdd->id);
> @@ -1021,7 +1023,6 @@ static int watchdog_cdev_register(struct watchdog_device *wdd)
> pr_err("%s: a legacy watchdog module is probably present.\n",
> wdd->info->identity);
> old_wd_data = NULL;
> - kfree(wd_data);
Are you sure about this ? put_device() isn't called on &wd_data->dev
(unlike the code further below). How do you trigger the double free,
or, in other words, how is watchdog_core_data_release() ever called
in this code path ?
device_initialize() says:
NOTE: Use put_device() to give up your reference instead of freeing
@dev directly once you have called this function.
so it looks like put_device() should be called instead of kfree().
Thanks,
Guenter
> return err;
> }
> }
>
next prev parent reply other threads:[~2020-08-23 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 7:13 [PATCH] watchdog: Fix double-free in watchdog_cdev_register Dinghao Liu
2020-08-23 19:06 ` Guenter Roeck [this message]
2020-08-24 2:13 ` dinghao.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03f9c262-3174-21e4-2211-df9fb2097457@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexander.sverdlin@nokia.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=krzysztof.sobota@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).