From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"sre@kernel.org" <sre@kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"wens@csie.org" <wens@csie.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"saravanak@google.com" <saravanak@google.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"jroedel@suse.de" <jroedel@suse.de>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"agross@kernel.org" <agross@kernel.org>,
"cw00.choi@samsung.com" <cw00.choi@samsung.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init
Date: Sat, 13 Feb 2021 12:26:59 +0000 [thread overview]
Message-ID: <0bf56f1c5eb8262bd734ceb81fc832655253adc0.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <YCfDAly9b0zHMpJT@kroah.com>
On Sat, 2021-02-13 at 13:16 +0100, Greg Kroah-Hartman wrote:
> On Sat, Feb 13, 2021 at 01:58:44PM +0200, Matti Vaittinen wrote:
> > A few drivers which need a delayed work-queue must cancel work at
> > exit.
> > Some of those implement remove solely for this purpose. Help
> > drivers
> > to avoid unnecessary remove and error-branch implementation by
> > adding
> > managed verision of delayed work initialization
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
>
> That's not a good idea. As this would kick in when the device is
> removed from the system, not when it is unbound from the driver,
> right?
>
> > ---
> > drivers/base/devres.c | 33 +++++++++++++++++++++++++++++++++
> > include/linux/device.h | 5 +++++
> > 2 files changed, 38 insertions(+)
> >
> > diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> > index fb9d5289a620..2879595bb5a4 100644
> > --- a/drivers/base/devres.c
> > +++ b/drivers/base/devres.c
> > @@ -1231,3 +1231,36 @@ void devm_free_percpu(struct device *dev,
> > void __percpu *pdata)
> > (void *)pdata));
> > }
> > EXPORT_SYMBOL_GPL(devm_free_percpu);
> > +
> > +static void dev_delayed_work_drop(struct device *dev, void *res)
> > +{
> > + cancel_delayed_work_sync(*(struct delayed_work **)res);
> > +}
> > +
> > +/**
> > + * devm_delayed_work_autocancel - Resource-managed work allocation
> > + * @dev: Device which lifetime work is bound to
> > + * @pdata: work to be cancelled when device exits
> > + *
> > + * Initialize work which is automatically cancelled when device
> > exits.
>
> There is no such thing in the driver model as "when device exits".
> Please use the proper terminology as I do not understand what you
> think
> this is doing here...
>
> > + * A few drivers need delayed work which must be cancelled before
> > driver
> > + * is unload to avoid accessing removed resources.
> > + * devm_delayed_work_autocancel() can be used to omit the explicit
> > + * cancelleation when driver is unload.
> > + */
> > +int devm_delayed_work_autocancel(struct device *dev, struct
> > delayed_work *w,
> > + void (*worker)(struct work_struct
> > *work))
> > +{
> > + struct delayed_work **ptr;
> > +
> > + ptr = devres_alloc(dev_delayed_work_drop, sizeof(*ptr),
> > GFP_KERNEL);
> > + if (!ptr)
> > + return -ENOMEM;
> > +
> > + INIT_DELAYED_WORK(w, worker);
> > + *ptr = w;
> > + devres_add(dev, ptr);
> > +
> > + return 0;
> > +}
> > +EXPORT_SYMBOL_GPL(devm_delayed_work_autocancel);
> > diff --git a/include/linux/device.h b/include/linux/device.h
> > index 1779f90eeb4c..192456198de7 100644
> > --- a/include/linux/device.h
> > +++ b/include/linux/device.h
> > @@ -27,6 +27,7 @@
> > #include <linux/uidgid.h>
> > #include <linux/gfp.h>
> > #include <linux/overflow.h>
> > +#include <linux/workqueue.h>
> > #include <linux/device/bus.h>
> > #include <linux/device/class.h>
> > #include <linux/device/driver.h>
> > @@ -249,6 +250,10 @@ void __iomem *devm_of_iomap(struct device
> > *dev,
> > struct device_node *node, int index,
> > resource_size_t *size);
> >
> > +/* delayed work which is cancelled when driver exits */
>
> Not when the "driver exits".
>
> There is two different lifespans here (well 3). Code and
> data*2. Don't
> confuse them as that will just cause lots of problems.
>
> The move toward more and more "devm" functions is not the way to go
> as
> they just more and more make things easier to get wrong.
>
> APIs should be impossible to get wrong, this one is going to be
> almost
> impossible to get right.
Thanks for prompt reply. I guess I must've misunderstood some of this
concept. Frankly to say, I don't understand how the devm based irq
management works and this does not. Maybe I'd better study this further
then.
Best Regards
Matti Vaittinen
next prev parent reply other threads:[~2021-02-13 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 11:58 [RFC PATCH 0/7] Add managed version of delayed work init Matti Vaittinen
2021-02-13 11:58 ` [RFC PATCH 1/7] drivers: base: Add resource " Matti Vaittinen
2021-02-13 12:16 ` Greg Kroah-Hartman
2021-02-13 12:26 ` Vaittinen, Matti [this message]
2021-02-13 12:38 ` gregkh
2021-02-13 13:18 ` Hans de Goede
2021-02-13 13:33 ` Greg Kroah-Hartman
2021-02-13 14:38 ` Hans de Goede
2021-02-13 14:52 ` Hans de Goede
2021-02-15 6:58 ` Matti Vaittinen
2021-02-13 15:03 ` Hans de Goede
2021-02-13 15:27 ` Guenter Roeck
2021-02-13 15:59 ` Hans de Goede
2021-02-13 18:17 ` Guenter Roeck
2021-02-15 7:22 ` Vaittinen, Matti
2021-02-15 10:37 ` Hans de Goede
2021-02-15 11:31 ` gregkh
2021-02-15 11:43 ` Hans de Goede
2021-02-15 13:12 ` Vaittinen, Matti
2021-02-13 12:18 ` [RFC PATCH 7/7] watchdog: retu_wdt: Clean-up by using managed " Matti Vaittinen
2021-02-18 16:28 ` [RFC PATCH 0/7] Add managed version of delayed " mark gross
2021-02-19 10:35 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bf56f1c5eb8262bd734ceb81fc832655253adc0.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=agross@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=jroedel@suse.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mgross@linux.intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).