From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-watchdog@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] watchdog: docs: kernel-api: don't reference removed functions
Date: Mon, 17 Dec 2018 12:07:55 -0800 [thread overview]
Message-ID: <20181217200755.GA29585@roeck-us.net> (raw)
In-Reply-To: <20181217191411.3254-1-wsa+renesas@sang-engineering.com>
On Mon, Dec 17, 2018 at 08:14:11PM +0100, Wolfram Sang wrote:
> Those functions are not only deprecated, but gone for good.
>
> Fixes: 62cd1c40ce1c ("watchdog: kill unref/ref ops")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Documentation/watchdog/watchdog-kernel-api.txt | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/watchdog/watchdog-kernel-api.txt b/Documentation/watchdog/watchdog-kernel-api.txt
> index 9b93953f69cf..3a91ef5af044 100644
> --- a/Documentation/watchdog/watchdog-kernel-api.txt
> +++ b/Documentation/watchdog/watchdog-kernel-api.txt
> @@ -128,8 +128,6 @@ struct watchdog_ops {
> int (*set_pretimeout)(struct watchdog_device *, unsigned int);
> unsigned int (*get_timeleft)(struct watchdog_device *);
> int (*restart)(struct watchdog_device *);
> - void (*ref)(struct watchdog_device *) __deprecated;
> - void (*unref)(struct watchdog_device *) __deprecated;
> long (*ioctl)(struct watchdog_device *, unsigned int, unsigned long);
> };
>
> @@ -218,8 +216,6 @@ they are supported. These optional routines/operations are:
> if a command is not supported. The parameters that are passed to the ioctl
> call are: watchdog_device, cmd and arg.
>
> -The 'ref' and 'unref' operations are no longer used and deprecated.
> -
> The status bits should (preferably) be set with the set_bit and clear_bit alike
> bit-operations. The status bits that are defined are:
> * WDOG_ACTIVE: this status bit indicates whether or not a watchdog timer device
> --
> 2.19.1
>
prev parent reply other threads:[~2018-12-17 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 19:14 [PATCH] watchdog: docs: kernel-api: don't reference removed functions Wolfram Sang
2018-12-17 20:07 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217200755.GA29585@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).