From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: mazziesaccount@gmail.com, Guenter Roeck <linux@roeck-us.net>,
heikki.haikola@fi.rohmeurope.com,
mikko.mutanen@fi.rohmeurope.com, lee.jones@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com, broonie@kernel.org,
gregkh@linuxfoundation.org, rafael@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
sre@kernel.org, lgirdwood@gmail.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, wim@linux-watchdog.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v7 00/10] support ROHM BD70528 PMIC
Date: Thu, 7 Feb 2019 07:57:38 +0200 [thread overview]
Message-ID: <20190207055738.GA5798@localhost.localdomain> (raw)
In-Reply-To: <87o97ovke3.fsf@codeaurora.org>
Moro Kalle,
On Wed, Feb 06, 2019 at 08:31:32PM +0200, Kalle Valo wrote:
> Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> writes:
>
> > Patch series introducing support for ROHM BD70528 PMIC
> >
> > Please note that patch 1 breaks compilation without patches 2 and 3
> > Knowing the bd718x7 driver is already in upstream, it might be good
> > if this change went through single tree, right?
>
> That would break bisect, please avoid that. So after applying patches
> from a patchset one by one the compilation should always succeed.
Right. Thanks for the reminder. Mark did also ask about this earlier.
This split was originally done to clearly point out changes impacting
in-tree drivers on separate subsystems/trees (mfd, clk and regulators).
But you are right, these should be squashed before applying. I have now
received acks from Mark and Stephen so I guess I can squash them even
though Lee has not yet commented anything yet. I guess that 7 previous
versions do already clearly enough point out these changes =)
I will squash them in next version. Thanks for the reminder.
>
> --
> Kalle Valo
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
prev parent reply other threads:[~2019-02-07 5:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 9:35 [PATCH v7 00/10] support ROHM BD70528 PMIC Matti Vaittinen
2019-02-06 9:36 ` [PATCH v7 01/10] mfd: bd718x7.h split to ROHM common and bd718x7 specific parts Matti Vaittinen
2019-02-06 9:38 ` [PATCH v7 02/10] regulator: bd718x7 use chip specific and generic data structs Matti Vaittinen
2019-02-06 9:38 ` [PATCH v7 03/10] clk: bd718x7: " Matti Vaittinen
2019-02-06 17:30 ` Stephen Boyd
2019-02-06 9:39 ` [PATCH v7 04/10] mfd: bd70528: Support ROHM bd70528 PMIC - core Matti Vaittinen
2019-02-06 9:39 ` [PATCH v7 05/10] clk: bd718x7: Support ROHM BD70528 clk block Matti Vaittinen
2019-02-06 17:31 ` Stephen Boyd
2019-02-07 6:01 ` Matti Vaittinen
2019-02-06 9:40 ` [PATCH v7 06/10] devicetree: bindings: Document first ROHM BD70528 bindings Matti Vaittinen
2019-02-06 9:40 ` [PATCH v7 07/10] gpio: Initial support for ROHM bd70528 GPIO block Matti Vaittinen
2019-02-06 9:40 ` [PATCH v7 08/10] rtc: bd70528: Initial support for ROHM bd70528 RTC Matti Vaittinen
2019-02-06 9:41 ` [PATCH v7 09/10] power: supply: Initial support for ROHM BD70528 PMIC charger block Matti Vaittinen
2019-02-06 9:41 ` [PATCH v7 10/10] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block Matti Vaittinen
2019-02-06 18:31 ` [PATCH v7 00/10] support ROHM BD70528 PMIC Kalle Valo
2019-02-07 5:57 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207055738.GA5798@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=kvalo@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=mturquette@baylibre.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).