From: Guenter Roeck <linux@roeck-us.net>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: wim@linux-watchdog.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet static
Date: Wed, 20 Mar 2019 07:57:46 -0700 [thread overview]
Message-ID: <20190320145746.GA10980@roeck-us.net> (raw)
In-Reply-To: <20190320134250.13348-1-yuehaibing@huawei.com>
On Wed, Mar 20, 2019 at 09:42:50PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/watchdog/sb_wdog.c:70:6: warning: symbol 'sbwdog_set' was not declared. Should it be static?
> drivers/watchdog/sb_wdog.c:84:6: warning: symbol 'sbwdog_pet' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sb_wdog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c
> index 3abae50..8264fced 100644
> --- a/drivers/watchdog/sb_wdog.c
> +++ b/drivers/watchdog/sb_wdog.c
> @@ -67,7 +67,7 @@ static DEFINE_SPINLOCK(sbwd_lock);
> *
> * wdog is the iomem address of the cfg register
> */
> -void sbwdog_set(char __iomem *wdog, unsigned long t)
> +static void sbwdog_set(char __iomem *wdog, unsigned long t)
> {
> spin_lock(&sbwd_lock);
> __raw_writeb(0, wdog);
> @@ -81,7 +81,7 @@ void sbwdog_set(char __iomem *wdog, unsigned long t)
> *
> * wdog is the iomem address of the cfg register
> */
> -void sbwdog_pet(char __iomem *wdog)
> +static void sbwdog_pet(char __iomem *wdog)
> {
> spin_lock(&sbwd_lock);
> __raw_writeb(__raw_readb(wdog) | 1, wdog);
> --
> 2.7.0
>
>
next prev parent reply other threads:[~2019-03-20 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 13:42 [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet static Yue Haibing
2019-03-20 14:57 ` Guenter Roeck [this message]
2019-03-20 19:27 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320145746.GA10980@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).