From: Guenter Roeck <linux@roeck-us.net>
To: Eugen.Hristev@microchip.com
Cc: Nicolas.Ferre@microchip.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wim@linux-watchdog.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: sama5d4: fix WDD value to be always set to max
Date: Wed, 8 May 2019 09:34:05 -0700 [thread overview]
Message-ID: <20190508163405.GB5495@roeck-us.net> (raw)
In-Reply-To: <1557324535-9050-1-git-send-email-eugen.hristev@microchip.com>
On Wed, May 08, 2019 at 02:15:03PM +0000, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> WDD value must be always set to max (0xFFF) otherwise the hardware
> block will reset the board on the first ping of the watchdog.
>
Not sure why setting WDD to the same value as WDV would do that,
but on the other side it looks like setting WDD to anything but
the maximum doesn't add any value either, so
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> drivers/watchdog/sama5d4_wdt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
> index 1e93c1b..d495336 100644
> --- a/drivers/watchdog/sama5d4_wdt.c
> +++ b/drivers/watchdog/sama5d4_wdt.c
> @@ -111,9 +111,7 @@ static int sama5d4_wdt_set_timeout(struct watchdog_device *wdd,
> u32 value = WDT_SEC2TICKS(timeout);
>
> wdt->mr &= ~AT91_WDT_WDV;
> - wdt->mr &= ~AT91_WDT_WDD;
> wdt->mr |= AT91_WDT_SET_WDV(value);
> - wdt->mr |= AT91_WDT_SET_WDD(value);
>
> /*
> * WDDIS has to be 0 when updating WDD/WDV. The datasheet states: When
> @@ -251,7 +249,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev)
>
> timeout = WDT_SEC2TICKS(wdd->timeout);
>
> - wdt->mr |= AT91_WDT_SET_WDD(timeout);
> + wdt->mr |= AT91_WDT_SET_WDD(WDT_SEC2TICKS(MAX_WDT_TIMEOUT));
> wdt->mr |= AT91_WDT_SET_WDV(timeout);
>
> ret = sama5d4_wdt_init(wdt);
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-05-08 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 14:15 [PATCH] watchdog: sama5d4: fix WDD value to be always set to max Eugen.Hristev
2019-05-08 16:34 ` Guenter Roeck [this message]
2019-05-09 6:04 ` Eugen.Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508163405.GB5495@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Eugen.Hristev@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).