linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	a.zummo@towertech.it, wim@linux-watchdog.org,
	u.kleine-koenig@pengutronix.de, bth@kamstrup.com
Subject: Re: [PATCH v2 4/5] rtc: pcf2127: add watchdog feature support
Date: Wed, 14 Aug 2019 06:34:50 -0700	[thread overview]
Message-ID: <20190814133450.GA32629@roeck-us.net> (raw)
In-Reply-To: <CAH+2xPDA4Ja_6Sgo0-Ak8KC5RKgE2E8CKyWargYaJMu52o_aoA@mail.gmail.com>

On Wed, Aug 14, 2019 at 03:25:55PM +0200, Bruno Thomsen wrote:
> Hi Guenter
> 
> Thanks for the quick review.
> 
> Den tir. 13. aug. 2019 kl. 18.19 skrev Guenter Roeck <linux@roeck-us.net>:
> >
> > On Tue, Aug 13, 2019 at 05:35:59PM +0200, Bruno Thomsen wrote:
> > > +static int pcf2127_wdt_start(struct watchdog_device *wdd)
> > > +{
> > > +     dev_info(wdd->parent, "watchdog enabled\n");
> > > +
> > > +     return pcf2127_wdt_ping(wdd);
> > > +}
> > > +
> > > +static int pcf2127_wdt_stop(struct watchdog_device *wdd)
> > > +{
> > > +     struct pcf2127 *pcf2127 = watchdog_get_drvdata(wdd);
> > > +
> > > +     dev_info(wdd->parent, "watchdog disabled\n");
> > > +
> >
> > There is a lot of noise in this driver. Please reconsider.
> 
> Would it be better if I remove the following lines:
> 
> dev_info(wdd->parent, "watchdog enabled\n");
> dev_info(wdd->parent, "watchdog disabled\n");
> dev_err(dev, "%s: watchdog registering failed\n", __func__);
> 
> and change this line to a dev_dbg():
> 
> dev_info(wdd->parent, "new watchdog timeout: %is (old: %is)\n",
>          new_timeout, wdd->timeout);
> 
> ?
> 
Yes.

Thanks,
Guenter

  reply	other threads:[~2019-08-14 13:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 15:35 [PATCH v2 0/5] rtc: pcf2127: tamper timestamp and watchdog feature support Bruno Thomsen
2019-08-13 15:35 ` [PATCH v2 1/5] rtc: pcf2127: convert to devm_rtc_allocate_device Bruno Thomsen
2019-08-13 15:35 ` [PATCH v2 2/5] rtc: pcf2127: cleanup register and bit defines Bruno Thomsen
2019-08-13 15:35 ` [PATCH v2 3/5] rtc: pcf2127: bugfix: read rtc disables watchdog Bruno Thomsen
2019-08-13 15:35 ` [PATCH v2 4/5] rtc: pcf2127: add watchdog feature support Bruno Thomsen
2019-08-13 16:19   ` Guenter Roeck
2019-08-14 13:25     ` Bruno Thomsen
2019-08-14 13:34       ` Guenter Roeck [this message]
2019-08-13 15:36 ` [PATCH v2 5/5] rtc: pcf2127: add tamper detection support Bruno Thomsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814133450.GA32629@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bruno.thomsen@gmail.com \
    --cc=bth@kamstrup.com \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).