From: Rob Herring <robh@kernel.org>
To: Xingyu Chen <xingyu.chen@amlogic.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Qianggui Song <qianggui.song@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
linux-watchdog@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog
Date: Fri, 25 Oct 2019 15:30:30 -0500 [thread overview]
Message-ID: <20191025203030.GA28391@bogus> (raw)
In-Reply-To: <1571983984-11771-3-git-send-email-xingyu.chen@amlogic.com>
On Fri, Oct 25, 2019 at 02:13:02PM +0800, Xingyu Chen wrote:
> The binding targets the Meson-A/C series compatible SoCs, in which the
> watchdog registers are in secure world.
>
> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
> ---
> .../bindings/watchdog/amlogic,meson-sec-wdt.yaml | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
> new file mode 100644
> index 00000000..0bbc807
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +# Copyright (c) 2019 Amlogic, Inc
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-wdt.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Amlogic Meson Secure Watchdog Timer
> +
> +maintainers:
> + - Xingyu Chen <xingyu.chen@amlogic.com>
> +
> +description: |+
> + Secure Watchdog Timer used in Meson-A/C series Compatible SoCs
> +
> +properties:
> + compatible:
> + enum:
> + - amlogic,meson-sec-wdt
If there are no other properties, then you don't need this. Just have
the secure firmware driver instantiate the watchdog.
> +
> + secure-monitor:
> + description: phandle to the secure-monitor node
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> + - compatible
> + - secure-monitor
> +
> +examples:
> + - |
> + watchdog {
> + compatible = "amlogic,meson-sec-wdt";
> + secure-monitor = <&sm>;
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-10-25 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 6:13 [PATCH v3 0/4] add meson secure watchdog driver Xingyu Chen
2019-10-25 6:13 ` [PATCH v3 1/4] firmware: meson_sm: add new SMC ID support for accessing secure watchdog Xingyu Chen
2019-10-25 6:13 ` [PATCH v3 2/4] dt-bindings: watchdog: add new binding for meson " Xingyu Chen
2019-10-25 20:30 ` Rob Herring [this message]
2019-10-28 8:35 ` Xingyu Chen
2019-10-29 20:51 ` Rob Herring
2019-10-30 12:59 ` Xingyu Chen
2019-10-30 13:41 ` Rob Herring
2019-10-31 12:40 ` Xingyu Chen
2019-10-25 6:13 ` [PATCH v3 3/4] watchdog: add meson secure watchdog driver Xingyu Chen
2019-11-02 15:44 ` Guenter Roeck
2019-10-25 6:13 ` [PATCH v3 4/4] arm64: dts: a1: add secure watchdog controller Xingyu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025203030.GA28391@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=narmstrong@baylibre.com \
--cc=qianggui.song@amlogic.com \
--cc=wim@linux-watchdog.org \
--cc=xingyu.chen@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).