From: Guenter Roeck <linux@roeck-us.net>
To: michaelsh@mellanox.com
Cc: wim@linux-watchdog.org, andy@infradead.org, dvhart@infradead.org,
linux-watchdog@vger.kernel.org,
platform-driver-x86@vger.kernel.org, vadimp@mellanox.com
Subject: Re: [PATCH v1 4/4] Documentation/watchdog: Add description of new watchdog type 3
Date: Sat, 18 Apr 2020 04:46:47 -0700 [thread overview]
Message-ID: <20200418114646.GB103392@roeck-us.net> (raw)
In-Reply-To: <20200416163514.7334-5-michaelsh@mellanox.com>
On Thu, Apr 16, 2020 at 07:35:14PM +0300, michaelsh@mellanox.com wrote:
> From: Michael Shych <michaelsh@mellanox.com>
>
> Add documentation with details of new type of Mellanox watchdog driver.
>
> Signed-off-by: Michael Shych <michaelsh@mellanox.com>
>
Stray empty line.
Also, the subject should reflect the driver name.
Guenter
> Reviewed-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
> Documentation/watchdog/mlx-wdt.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/watchdog/mlx-wdt.rst b/Documentation/watchdog/mlx-wdt.rst
> index bf5bafac47f0..fa0a94e5c82e 100644
> --- a/Documentation/watchdog/mlx-wdt.rst
> +++ b/Documentation/watchdog/mlx-wdt.rst
> @@ -24,10 +24,19 @@ Type 2:
> Maximum timeout is 255 sec.
> Get time-left is supported.
>
> +Type 3:
> + Same as Type 2 with extended maximum timeout period.
> + Maximum timeout is 65535 sec.
> +
> Type 1 HW watchdog implementation exist in old systems and
> all new systems have type 2 HW watchdog.
> Two types of HW implementation have also different register map.
>
> +Type 3 HW watchdog implementation can exist on all Mellanox systems
> +with new programmer logic device.
> +It's differentiated by WD capability bit.
> +Old systems still have only one main watchdog.
> +
> Mellanox system can have 2 watchdogs: main and auxiliary.
> Main and auxiliary watchdog devices can be enabled together
> on the same system.
> --
> 2.11.0
>
next prev parent reply other threads:[~2020-04-18 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 16:35 [PATCH v1 0/4] support watchdog with longer timeout period michaelsh
2020-04-16 16:35 ` [PATCH v1 1/4] platform_data/mlxreg: support new watchdog type " michaelsh
2020-04-16 16:35 ` [PATCH v1 2/4] platform/x86: mlx-platform: support new watchdog type with longer timeout michaelsh
2020-04-16 16:35 ` [PATCH v1 3/4] watchdog: mlx-wdt: support new watchdog type with longer timeout period michaelsh
2020-04-18 11:45 ` Guenter Roeck
2020-04-16 16:35 ` [PATCH v1 4/4] Documentation/watchdog: Add description of new watchdog type 3 michaelsh
2020-04-18 11:46 ` Guenter Roeck [this message]
2020-04-28 13:06 ` Michael Shych
2020-04-17 13:41 ` [PATCH v1 0/4] support watchdog with longer timeout period Andy Shevchenko
2020-04-20 15:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418114646.GB103392@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).