From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F43C83003 for ; Wed, 29 Apr 2020 12:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2532C208FE for ; Wed, 29 Apr 2020 12:52:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbgD2MwG (ORCPT ); Wed, 29 Apr 2020 08:52:06 -0400 Received: from mga09.intel.com ([134.134.136.24]:25045 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbgD2MwF (ORCPT ); Wed, 29 Apr 2020 08:52:05 -0400 IronPort-SDR: Wmhk3jsCsvoC6Z3/7SNjhmpPS5r340ziCuvzcwNZliu5MqaCTcyG24VXaE6gDoy+SOq0s+i1lI IB7nztwoP6jw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 05:52:04 -0700 IronPort-SDR: iorrW9uinQQLgZ3jMTcDE4CwtW/fP8p8ODYzeuGnvWB09QfLQC2sW/R9h91q7ig8VKPY2q4znR Xsk/jxy/WH8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,332,1583222400"; d="scan'208";a="367795695" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 29 Apr 2020 05:52:01 -0700 Received: by lahna (sSMTP sendmail emulation); Wed, 29 Apr 2020 15:52:00 +0300 Date: Wed, 29 Apr 2020 15:52:00 +0300 From: Mika Westerberg To: Arnd Bergmann Cc: Guenter Roeck , Andy Shevchenko , Lee Jones , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: iTCO: fix link error Message-ID: <20200429125200.GO487496@lahna.fi.intel.com> References: <20200428212959.2993304-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428212959.2993304-1-arnd@arndb.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Tue, Apr 28, 2020 at 11:29:11PM +0200, Arnd Bergmann wrote: > When the MFD driver is a loadable module, the watchdog driver fails > to get linked into the kernel: > > drivers/watchdog/iTCO_wdt.o: In function `update_no_reboot_bit_pmc': > iTCO_wdt.c:(.text+0x54f): undefined reference to `intel_pmc_gcr_update' > > The code is written to support operation without the MFD driver, so > add a Kconfig dependency that allows this, while disallowing the watchdog > to be built-in when the MFD driver is a module. > > Fixes: 25f1ca31e230 ("platform/x86: intel_pmc_ipc: Convert to MFD") > Signed-off-by: Arnd Bergmann Reviewed-by: Mika Westerberg