From: Guenter Roeck <linux@roeck-us.net>
To: Michael Shych <michaelsh@mellanox.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Vadim Pasternak <vadimp@mellanox.com>
Subject: Re: [PATCH v3 0/4] support watchdog with longer timeout period
Date: Mon, 4 May 2020 06:39:45 -0700 [thread overview]
Message-ID: <20200504133945.GA86470@roeck-us.net> (raw)
In-Reply-To: <AM6PR05MB6168FA74FF9554A3E33601D1D9A90@AM6PR05MB6168.eurprd05.prod.outlook.com>
On Sun, May 03, 2020 at 04:13:54PM +0000, Michael Shych wrote:
>
>
> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Sent: Sunday, May 3, 2020 7:11 PM
> > To: Michael Shych <michaelsh@mellanox.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>; Wim Van Sebroeck <wim@linux-
> > watchdog.org>; Andy Shevchenko <andy@infradead.org>; Darren Hart
> > <dvhart@infradead.org>; linux-watchdog@vger.kernel.org; Platform Driver
> > <platform-driver-x86@vger.kernel.org>; Vadim Pasternak
> > <vadimp@mellanox.com>
> > Subject: Re: [PATCH v3 0/4] support watchdog with longer timeout period
> >
> > On Sun, May 3, 2020 at 8:34 AM <michaelsh@mellanox.com> wrote:
> > >
> > > From: Michael Shych <michaelsh@mellanox.com>
> > >
> > > This patchset adds support of extended new watchdog type 3 of Mellanox
> > > Ethernet and Infiniband switch systems.
> > > This type of watchdog can have a timeout period longer than 255 or 32 sec.
> > > as it was before.
> > >
> >
> > If you ignore my tags, why are you bothering about changes at all?
>
> Sorry that I missed it.
> Should I resend this patchset?
> If yes, as still v3 or new one v4?
>
If you resend as v3 but make changes, how do you expect the maintainers
to know which v3 is the correct one ?
Guenter
> >
> > > Michael Shych (4):
> > > platform_data/mlxreg: support new watchdog type with longer timeout
> > > period
> > > platform/x86: mlx-platform: support new watchdog type with longer
> > > timeout
> > > watchdog: mlx-wdt: support new watchdog type with longer timeout
> > > period
> > > docs: watchdog: mlx-wdt: Add description of new watchdog type 3
> > >
> > > Documentation/watchdog/mlx-wdt.rst | 10 ++++
> > > drivers/platform/x86/mlx-platform.c | 106
> > ++++++++++++++++++++++++++++++
> > > drivers/watchdog/mlx_wdt.c | 73 ++++++++++++++++++++----
> > > include/linux/platform_data/mlxreg.h | 5 +-
> > > 4 files changed, 182 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.11.0
> > >
> >
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
prev parent reply other threads:[~2020-05-04 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 5:34 [PATCH v3 0/4] support watchdog with longer timeout period michaelsh
2020-05-03 5:34 ` [PATCH v3 1/4] platform_data/mlxreg: support new watchdog type " michaelsh
2020-05-03 5:34 ` [PATCH v3 2/4] platform/x86: mlx-platform: support new watchdog type with longer timeout michaelsh
2020-05-03 5:34 ` [PATCH v3 3/4] watchdog: mlx-wdt: support new watchdog type with longer timeout period michaelsh
2020-05-03 5:34 ` [PATCH v3 4/4] docs: watchdog: mlx-wdt: Add description of new watchdog type 3 michaelsh
2020-05-03 16:10 ` [PATCH v3 0/4] support watchdog with longer timeout period Andy Shevchenko
2020-05-03 16:13 ` Michael Shych
2020-05-04 13:39 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504133945.GA86470@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).