From: Guenter Roeck <linux@roeck-us.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-watchdog@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: watchdog: m54xx: Add missing include
Date: Fri, 8 May 2020 12:54:24 -0700 [thread overview]
Message-ID: <20200508195424.GB65952@roeck-us.net> (raw)
In-Reply-To: <87blmyjjtf.fsf@nanos.tec.linutronix.de>
On Fri, May 08, 2020 at 09:41:32PM +0200, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Fri, 08 May 2020 21:26:58 +0200
>
> A recent cleanup removed the mm.h include from uaccess_no.h in
> m68k. This breaks the build of the m54xx watchdog driver:
>
> drivers/watchdog/m54xx_wdt.c:49:9: error: implicit declaration of function '__raw_readl'
>
> Due to magic include chains the inclusion of mm.h in uaccess_no.h pulled in io.h.
>
> Include 'linux/io.h' explicitely to fix this.
>
> Fixes: 9e860351550b ("m68knommu: Remove mm.h include from uaccess_no.h")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-watchdog@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/m54xx_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/watchdog/m54xx_wdt.c
> +++ b/drivers/watchdog/m54xx_wdt.c
> @@ -29,6 +29,7 @@
> #include <linux/bitops.h>
> #include <linux/ioport.h>
> #include <linux/uaccess.h>
> +#include <linux/io.h>
>
> #include <asm/coldfire.h>
> #include <asm/m54xxsim.h>
prev parent reply other threads:[~2020-05-08 19:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 19:41 watchdog: m54xx: Add missing include Thomas Gleixner
2020-05-08 19:54 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508195424.GB65952@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).