From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 0/3] Use MFD for Dallas/Maxim DS1374 driver series
Date: Mon, 22 Jun 2020 13:25:37 +0200 [thread overview]
Message-ID: <20200622112537.GE131826@piout.net> (raw)
In-Reply-To: <HK2PR01MB3281DAE412911621A7F8963BFA970@HK2PR01MB3281.apcprd01.prod.exchangelabs.com>
Hi,
On 22/06/2020 10:03:25+0000, Johnson CH Chen (陳昭勳) wrote:
> Hello all,
>
> This patch set uses MFD structure for DS1374 so that RTC and Watchdog
> functions can be separately. Therefore, we can add more Watchdog
> subfunctions here.
>
> A DS1374 MFD core driver supports the I2C communication to RTC and
> Watchdog devices.
>
> 1. Add DS1374 MFD core driver with I2C bus.
> 2. Let DS1374 RTC driver has RTC and Alarm functions only.
> 3. Add DS1374 Watchdog driver.
>
For reference, this was the last attempt:
https://lore.kernel.org/linux-rtc/20170718092245.tc5oosbbb6lzvqpy@dell/
The main issue I see with your series is that there is no way to select
which of the rtc or the watchdog driver has to be used as IIRC each
function is mutually exclusive. I think you should work on the DT
bindings, addressing the few remaining comments.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-22 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 10:03 [PATCH 0/3] Use MFD for Dallas/Maxim DS1374 driver series Johnson CH Chen (陳昭勳)
2020-06-22 11:25 ` Alexandre Belloni [this message]
2020-06-23 3:19 ` Johnson CH Chen (陳昭勳)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622112537.GE131826@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=JohnsonCH.Chen@moxa.com \
--cc=a.zummo@towertech.it \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).