From: Guenter Roeck <linux@roeck-us.net>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: iTCO_wdt: Make use of the helper function devm_platform_ioremap_resource()
Date: Tue, 7 Sep 2021 05:39:36 -0700 [thread overview]
Message-ID: <20210907123936.GB4989@roeck-us.net> (raw)
In-Reply-To: <20210907074230.2757-1-caihuoqing@baidu.com>
On Tue, Sep 07, 2021 at 03:42:29PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/iTCO_wdt.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 643c6c2d0b72..ebf7e5bc1199 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -96,7 +96,6 @@ struct iTCO_wdt_private {
> * NO_REBOOT flag is Memory-Mapped GCS register bit 5 (TCO version 2),
> * or memory-mapped PMC register bit 4 (TCO version 3).
> */
> - struct resource *gcs_pmc_res;
> unsigned long __iomem *gcs_pmc;
> /* the lock for io operations */
> spinlock_t io_lock;
> @@ -503,10 +502,7 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
> */
> if (p->iTCO_version >= 2 && p->iTCO_version < 6 &&
> !pdata->no_reboot_use_pmc) {
> - p->gcs_pmc_res = platform_get_resource(pdev,
> - IORESOURCE_MEM,
> - ICH_RES_MEM_GCS_PMC);
> - p->gcs_pmc = devm_ioremap_resource(dev, p->gcs_pmc_res);
> + p->gcs_pmc = devm_platform_ioremap_resource(pdev, ICH_RES_MEM_GCS_PMC);
> if (IS_ERR(p->gcs_pmc))
> return PTR_ERR(p->gcs_pmc);
> }
> --
> 2.25.1
>
prev parent reply other threads:[~2021-09-07 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 7:42 [PATCH] watchdog: iTCO_wdt: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-07 12:39 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907123936.GB4989@roeck-us.net \
--to=linux@roeck-us.net \
--cc=caihuoqing@baidu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).