linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Srinivas Neeli <sneeli@xilinx.com>,
	Michal Simek <michals@xilinx.com>,
	Shubhrajyoti Datta <shubhraj@xilinx.com>,
	Srinivas Goud <sgoud@xilinx.com>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	git <git@xilinx.com>
Subject: Re: [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window watchdog support
Date: Wed, 24 Mar 2021 07:01:33 -0700	[thread overview]
Message-ID: <2241024e-3791-4733-4d4a-a4ea12582e92@roeck-us.net> (raw)
In-Reply-To: <DM6PR02MB53866BB023B6B525D48B76F9AF639@DM6PR02MB5386.namprd02.prod.outlook.com>

On 3/23/21 11:04 PM, Srinivas Neeli wrote:
> Hi Guenter,
> 
> Thanks for review
> 
>> -----Original Message-----
>> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
>> Sent: Tuesday, March 16, 2021 8:01 AM
>> To: Srinivas Neeli <sneeli@xilinx.com>; Michal Simek <michals@xilinx.com>;
>> Shubhrajyoti Datta <shubhraj@xilinx.com>; Srinivas Goud
>> <sgoud@xilinx.com>
>> Cc: wim@linux-watchdog.org; linux-watchdog@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git
>> <git@xilinx.com>
>> Subject: Re: [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window
>> watchdog support
>>
>> On 3/15/21 3:46 AM, Srinivas Neeli wrote:
>>> Versal watchdog driver uses Window watchdog mode. Window watchdog
>>> timer(WWDT) contains closed(first) and open(second) window with
>>> 32 bit width. WWDT will generate an interrupt after the first window
>>> timeout and reset signal after the second window timeout. Timeout and
>>> Pre-timeout configuration, Stop and Refresh trigger only in open
>>> window.
>>>
>>> Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
>>
>> I think this should be a separate watchdog driver. There is pretty much no
>> overlap with the existing driver.
> 
> Xilinx AXI Timebase Watchdog Timer supports two independent modes
> 1)Timebase Watchdog Mode
> 2)Window Watchdog Timer Mode.
> Current of_xilinx_wdt.c driver already have support for Timebase Watchdog Mode, but Window watchdog timer Mode feature is missing.
> Versal platform contains customized AXI Timebase Watchdog Timer, which supports Window Watchdog Timer Mode.
> For that reason we are creating common driver for both the modes.
> 

That is not an argument. The two watchdogs are still completely different,
and there is no value having a single driver.

Guenter

  reply	other threads:[~2021-03-24 14:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 10:46 [PATCH 0/9] watchdog: of_xilinx_wdt: Update on xilinx watchdog driver Srinivas Neeli
2021-03-15 10:46 ` [PATCH 1/9] watchdog: of_xilinx_wdt: Add comment to spinlock Srinivas Neeli
2021-03-16  2:21   ` Guenter Roeck
2021-03-15 10:46 ` [PATCH 2/9] watchdog: of_xilinx_wdt: Used BIT macro Srinivas Neeli
2021-03-16  2:23   ` Guenter Roeck
2021-03-24  6:06     ` Srinivas Neeli
2021-03-15 10:46 ` [PATCH 3/9] watchdog: of_xilinx_wdt: Used dev_dbg() Srinivas Neeli
2021-03-16  2:27   ` Guenter Roeck
2021-03-15 10:46 ` [PATCH 4/9] watchdog: of_xilinx_wdt: Initialize watchdog via data structure Srinivas Neeli
2021-03-15 10:46 ` [PATCH 5/9] watchdog: of_xilinx_wdt: Introduce wdttype enum for identification Srinivas Neeli
2021-03-15 10:46 ` [PATCH 6/9] dt-bindings: watchdog: xilinx: Add binding for Versal watchdog Srinivas Neeli
2021-03-15 10:46 ` [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window watchdog support Srinivas Neeli
2021-03-16  2:31   ` Guenter Roeck
2021-03-24  6:04     ` Srinivas Neeli
2021-03-24 14:01       ` Guenter Roeck [this message]
2021-03-15 10:46 ` [PATCH 8/9] watchdog: of_xilinx_wdt: Remove passing null pointer Srinivas Neeli
2021-03-16  2:33   ` Guenter Roeck
2021-03-15 10:46 ` [PATCH 9/9] watchdog: of_xilinx_wdt: Skip printing pointer value Srinivas Neeli
2021-03-16  2:34   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2241024e-3791-4733-4d4a-a4ea12582e92@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=git@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=michals@xilinx.com \
    --cc=sgoud@xilinx.com \
    --cc=shubhraj@xilinx.com \
    --cc=sneeli@xilinx.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).