From: Fengquan Chen <fengquan.chen@mediatek.com>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-watchdog@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <tinghan.shen@mediatek.com>, <randy.wu@mediatek.com>,
<rex-bc.chen@mediatek.com>, <christine.zhu@mediatek.com>,
<joe.yang@mediatek.com>, <zhishuang.zhang@mediatek.com>
Subject: Re: [PATCH] watchdog: mtk: add disable_wdt_extrst support
Date: Fri, 3 Sep 2021 14:51:28 +0800 [thread overview]
Message-ID: <242e9e2ed9c2c071c4b05d11f276642e996e03b6.camel@mediatek.com> (raw)
In-Reply-To: <5fe9c774-c619-604e-1f74-12ff6bfe826f@roeck-us.net>
On Thu, 2021-09-02 at 06:43 -0700, Guenter Roeck wrote:
> On 9/2/21 1:04 AM, Fengquan Chen wrote:
> > From: "fengquan.chen" <fengquan.chen@mediatek.com>
>
> There should not be such From: line.
Thanks, i have removed it and uploaded a new version:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=541567
>
> >
> > In some cases, we may need watchdog just to trigger an
> > internal soc reset without sending any output signal.
> >
> > Provide a disable_wdt_extrst parameter for configuration.
> > We can disable or enable it just by configuring dts.
> >
> > igned-off-by: Fengquan Chen <fengquan.chen@mediatek.com>
>
> Missing "S".
Thanks, has been added back in v2.
>
> > ---
> > drivers/watchdog/mtk_wdt.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/watchdog/mtk_wdt.c
> > b/drivers/watchdog/mtk_wdt.c
> > index 97ca993..4824c07 100644
> > --- a/drivers/watchdog/mtk_wdt.c
> > +++ b/drivers/watchdog/mtk_wdt.c
> > @@ -63,6 +63,7 @@ struct mtk_wdt_dev {
> > void __iomem *wdt_base;
> > spinlock_t lock; /* protects WDT_SWSYSRST reg */
> > struct reset_controller_dev rcdev;
> > + bool disable_wdt_extrst;
> > };
> >
> > struct mtk_wdt_data {
> > @@ -240,6 +241,8 @@ static int mtk_wdt_start(struct watchdog_device
> > *wdt_dev)
> >
> > reg = ioread32(wdt_base + WDT_MODE);
> > reg &= ~(WDT_MODE_IRQ_EN | WDT_MODE_DUAL_EN);
> > + if (mtk_wdt->disable_wdt_extrst)
> > + reg &= ~WDT_MODE_EXRST_EN;
> > reg |= (WDT_MODE_EN | WDT_MODE_KEY);
> > iowrite32(reg, wdt_base + WDT_MODE);
> >
> > @@ -309,6 +312,10 @@ static int mtk_wdt_probe(struct
> > platform_device *pdev)
> > if (err)
> > return err;
> > }
> > +
> > + mtk_wdt->disable_wdt_extrst =
> > + of_property_read_bool(dev->of_node, "disable_extrst");
> > +
>
> The new property needs to be documented and approved by a DT
> maintainer
> (separate patch). Something like "mtk,disable-extrst" would probably
> be
> a better property name.
>
> Guenter
Thanks, the property name has been modified, and related dt-binding
has
been added,see series 541567
Best Regards
Fengquan
next prev parent reply other threads:[~2021-09-03 6:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 8:04 [PATCH] watchdog: mtk: add disable_wdt_extrst support Fengquan Chen
2021-09-02 8:04 ` Fengquan Chen
2021-09-02 13:43 ` Guenter Roeck
2021-09-03 6:51 ` Fengquan Chen [this message]
2021-09-02 13:39 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=242e9e2ed9c2c071c4b05d11f276642e996e03b6.camel@mediatek.com \
--to=fengquan.chen@mediatek.com \
--cc=christine.zhu@mediatek.com \
--cc=joe.yang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=randy.wu@mediatek.com \
--cc=rex-bc.chen@mediatek.com \
--cc=tinghan.shen@mediatek.com \
--cc=wim@linux-watchdog.org \
--cc=zhishuang.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).