From: Jan Kiszka <jan.kiszka@siemens.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tero Kristo <t-kristo@ti.com>,
"Su, Bao Cheng (RC-CN DF FA R&D)" <baocheng.su@siemens.com>
Subject: Re: [RFC][PATCH] watchdog: rti-wdt: Provide set_timeout handler to make existing userspace happy
Date: Mon, 22 Apr 2024 07:36:40 +0200 [thread overview]
Message-ID: <611a79db-4c4c-4538-a67e-370a777387ab@siemens.com> (raw)
In-Reply-To: <e6e3f905-3de5-469c-a47e-179fe23c66df@roeck-us.net>
On 22.04.24 01:50, Guenter Roeck wrote:
> On Mon, Sep 13, 2021 at 01:41:43PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Prominent userspace - systemd - cannot handle watchdogs without
>> WDIOF_SETTIMEOUT, even if it was configured to the same time as the
>> driver selected or was used by firmware to start the watchdog. To avoid
>> failing in this case, implement a handler that only fails if a deviating
>> set_timeout is requested.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> NACK.
>
> This will need to be fixed in systemd. set_timeout is and will remain
> optional.
Err, this patch was sent in 2021, and even systemd is long fixed (since
v250).
Jan
--
Siemens AG, Technology
Linux Expert Center
prev parent reply other threads:[~2024-04-22 5:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 11:41 [RFC][PATCH] watchdog: rti-wdt: Provide set_timeout handler to make existing userspace happy Jan Kiszka
2021-09-13 14:37 ` Guenter Roeck
2024-04-21 8:49 ` Francesco Dolcini
2024-04-22 5:35 ` Jan Kiszka
2024-04-22 8:20 ` Francesco Dolcini
2024-04-22 8:23 ` Francesco Dolcini
2024-04-21 23:50 ` Guenter Roeck
2024-04-22 5:36 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=611a79db-4c4c-4538-a67e-370a777387ab@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=baocheng.su@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=t-kristo@ti.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).