From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: iTCO: fix link error
Date: Wed, 29 Apr 2020 05:26:32 -0700 [thread overview]
Message-ID: <645115f0-5d3d-d8e5-9c26-64378e0d1c6f@roeck-us.net> (raw)
In-Reply-To: <20200428212959.2993304-1-arnd@arndb.de>
On 4/28/20 2:29 PM, Arnd Bergmann wrote:
> When the MFD driver is a loadable module, the watchdog driver fails
> to get linked into the kernel:
>
> drivers/watchdog/iTCO_wdt.o: In function `update_no_reboot_bit_pmc':
> iTCO_wdt.c:(.text+0x54f): undefined reference to `intel_pmc_gcr_update'
>
> The code is written to support operation without the MFD driver, so
> add a Kconfig dependency that allows this, while disallowing the watchdog
> to be built-in when the MFD driver is a module.
>
> Fixes: 25f1ca31e230 ("platform/x86: intel_pmc_ipc: Convert to MFD")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 66ca69f30f01..67a83578810e 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1217,6 +1217,7 @@ config ITCO_WDT
> depends on (X86 || IA64) && PCI
> select WATCHDOG_CORE
> depends on I2C || I2C=n
> + depends on MFD_INTEL_PMC_BXT || !MFD_INTEL_PMC_BXT
> select LPC_ICH if !EXPERT
> select I2C_I801 if !EXPERT && I2C
> ---help---
>
next prev parent reply other threads:[~2020-04-29 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 21:29 [PATCH] watchdog: iTCO: fix link error Arnd Bergmann
2020-04-28 22:05 ` Andy Shevchenko
2020-04-29 12:26 ` Guenter Roeck [this message]
2020-04-29 12:52 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645115f0-5d3d-d8e5-9c26-64378e0d1c6f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).