From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Fabio Aiuto <fabio.aiuto@engicam.com>
Subject: Re: [RFC PATCH v2 2/6] dt-bindings: mfd: bd96801 PMIC core
Date: Thu, 18 Apr 2024 19:28:29 +0200 [thread overview]
Message-ID: <675cd641-7322-43d5-a33a-7f0be48c380c@linaro.org> (raw)
In-Reply-To: <7541fb24-894a-439e-8f9a-b18f04e06afe@gmail.com>
On 15/04/2024 10:28, Matti Vaittinen wrote:
>>
>> Missing allOf and $ref to watchdog.yaml
>
> Huh. The watchdog.yaml contains:
>
> select:
> properties:
> $nodename:
> pattern: "^watchdog(@.*|-([0-9]|[1-9][0-9]+))?$"
>
> properties:
> $nodename:
> pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
>
>
> This means the watchdog _must_ have own sub-node inside the PMIC node,
Yes, that's a bit of a trouble. Then instead maybe just add timeout-sec
with maxItems: 2.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-18 17:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 11:20 [RFC PATCH v2 0/6] Support ROHM BD96801 scalable PMIC Matti Vaittinen
2024-04-12 11:21 ` [RFC PATCH v2 1/6] dt-bindings: ROHM BD96801 PMIC regulators Matti Vaittinen
2024-04-13 21:27 ` Krzysztof Kozlowski
2024-04-15 6:51 ` Matti Vaittinen
2024-04-15 15:29 ` Krzysztof Kozlowski
2024-04-12 11:21 ` [RFC PATCH v2 2/6] dt-bindings: mfd: bd96801 PMIC core Matti Vaittinen
2024-04-13 21:33 ` Krzysztof Kozlowski
2024-04-13 21:36 ` Krzysztof Kozlowski
2024-04-15 5:50 ` Matti Vaittinen
2024-04-15 6:24 ` Matti Vaittinen
2024-04-15 15:25 ` Krzysztof Kozlowski
2024-04-15 8:28 ` Matti Vaittinen
2024-04-18 17:28 ` Krzysztof Kozlowski [this message]
2024-04-19 5:48 ` Matti Vaittinen
2024-04-12 11:22 ` [RFC PATCH v2 3/6] mfd: support ROHM BD96801 " Matti Vaittinen
2024-04-12 11:22 ` [RFC PATCH v2 4/6] regulator: bd96801: ROHM BD96801 PMIC regulators Matti Vaittinen
2024-04-12 11:22 ` [RFC PATCH v2 5/6] watchdog: ROHM BD96801 PMIC WDG driver Matti Vaittinen
2024-04-17 4:29 ` George Cherian
2024-04-17 7:35 ` Matti Vaittinen
2024-04-17 18:20 ` Matti Vaittinen
2024-04-12 11:23 ` [RFC PATCH v2 6/6] MAINTAINERS: Add ROHM BD96801 'scalable PMIC' entries Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675cd641-7322-43d5-a33a-7f0be48c380c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.aiuto@engicam.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).