From: Guenter Roeck <linux@roeck-us.net>
To: Jiri Slaby <jirislaby@kernel.org>,
Curtis Klein <curtis.klein@hpe.com>,
wim@linux-watchdog.org
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3] watchdog: Add hrtimer-based pretimeout feature
Date: Thu, 2 Sep 2021 07:05:15 -0700 [thread overview]
Message-ID: <7fdd262e-84fb-0c34-baa9-162130f1e109@roeck-us.net> (raw)
In-Reply-To: <67d601c9-8f95-cb10-40df-4d962ec6f9ba@kernel.org>
On 9/1/21 11:55 PM, Jiri Slaby wrote:
> On 03. 02. 21, 21:11, Curtis Klein wrote:
>> This adds the option to use a hrtimer to generate a watchdog pretimeout
>> event for hardware watchdogs that do not natively support watchdog
>> pretimeouts.
>>
>> With this enabled, all watchdogs will appear to have pretimeout support
>> in userspace. If no pretimeout value is set, there will be no change in
>> the watchdog's behavior.
>
> Hi,
>
> on my Dell Latitude 7280, CONFIG_WATCHDOG_HRTIMER_PRETIMEOUT=y causes all reboot, kexec, suspend to panic. Disabling that option makes it all work again. Provided it happens very late in the process, I don't know how to grab some logs...
>
> Any ideas?
>
AFAICS the timer does not stop on reboot. I think we'll need to augment the code
to do that.
Guenter
> ...
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -73,6 +73,14 @@ config WATCHDOG_SYSFS
>> Say Y here if you want to enable watchdog device status read through
>> sysfs attributes.
>> +config WATCHDOG_HRTIMER_PRETIMEOUT
>> + bool "Enable watchdog hrtimer-based pretimeouts"
>> + help
>> + Enable this if you want to use a hrtimer timer based pretimeout for
>> + watchdogs that do not natively support pretimeout support. Be aware
>> + that because this pretimeout functionality uses hrtimers, it may not
>> + be able to fire before the actual watchdog fires in some situations.
>
> thanks,
next prev parent reply other threads:[~2021-09-02 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 20:11 [PATCH v3] watchdog: Add hrtimer-based pretimeout feature Curtis Klein
2021-02-04 1:35 ` Guenter Roeck
2021-09-02 6:55 ` Jiri Slaby
2021-09-02 14:05 ` Guenter Roeck [this message]
2021-09-04 8:16 ` was [Re: [PATCH v3] watchdog: Add hrtimer-based pretimeout feature] Jiri Slaby
[not found] ` <54d77fb1-2531-c6ed-738e-9f661443b097@kernel.org>
2021-09-05 22:22 ` Klein, Curtis
2021-09-05 22:56 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fdd262e-84fb-0c34-baa9-162130f1e109@roeck-us.net \
--to=linux@roeck-us.net \
--cc=curtis.klein@hpe.com \
--cc=jirislaby@kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).