From: Guenter Roeck <linux@roeck-us.net>
To: Denis Efremov <efremov@linux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
open list <linux-kernel@vger.kernel.org>,
linux-mips@linux-mips.org, Paul Burton <paulburton@kernel.org>
Subject: Re: [PATCH 0/2] watchdog: mtx-1: Relax build dependencies
Date: Wed, 11 Dec 2019 17:39:41 -0800 [thread overview]
Message-ID: <87f90857-633f-2437-4a26-a3b3dd7ea7c7@roeck-us.net> (raw)
In-Reply-To: <1a3eb533-b273-f903-ccaf-fdeaea9da51a@linux.com>
On 12/11/19 3:46 PM, Denis Efremov wrote:
> Hi,
>
> Thanks for the fix.
> I tested the compilation with these patches.
> You can add my:
> Tested-by: Denis Efremov <efremov@linux.com>
>
> Look like this error could be fixed the same way:
> In file included from drivers/watchdog/ar7_wdt.c:29:
> ./arch/mips/include/asm/mach-ar7/ar7.h: In function ‘ar7_is_titan’:
> ./arch/mips/include/asm/mach-ar7/ar7.h:111:24: error: implicit declaration of function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’? [-Werror=implicit-function-declaration]
>
This is yet another old-style watchdog driver which should be left alone
unless it has a bug that needs to be fixed. Really, if anyone out there
is still using this driver, converting it to use the watchdog core
would make much more sense.
Guenter
next prev parent reply other threads:[~2019-12-12 1:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 21:02 [PATCH 0/2] watchdog: mtx-1: Relax build dependencies Florian Fainelli
2019-12-11 21:02 ` [PATCH 1/2] watchdog: mtx-1: Drop au1000.h header inclusion Florian Fainelli
2019-12-12 1:35 ` Guenter Roeck
2019-12-12 3:38 ` Florian Fainelli
2019-12-12 18:19 ` Guenter Roeck
2019-12-12 18:28 ` Florian Fainelli
2019-12-11 21:02 ` [PATCH 2/2] watchdog: Relax dependencies for CONFIG_WDT_MTX1 Florian Fainelli
2019-12-11 23:46 ` [PATCH 0/2] watchdog: mtx-1: Relax build dependencies Denis Efremov
2019-12-12 1:39 ` Guenter Roeck [this message]
2019-12-12 3:41 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f90857-633f-2437-4a26-a3b3dd7ea7c7@roeck-us.net \
--to=linux@roeck-us.net \
--cc=efremov@linux.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).