From: Tao Ren <taoren@fb.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH] watchdog: core: suppress "watchdog did not stop" message
Date: Fri, 16 Nov 2018 00:37:28 +0000 [thread overview]
Message-ID: <9a43bb84-f476-d6c8-886a-2120312ee8e7@fb.com> (raw)
In-Reply-To: <20181116001938.GA16009@roeck-us.net>
On 11/15/18 4:19 PM, Guenter Roeck wrote:
> NACK. This message is displayed if/when the watchdog application
> exits without stopping the watchdog and/or without closing properly.
> This _is_ critical since it will reboot the system after the next
> timeout period.
>
> If userspace triggers this message on purpose (eg by the mentioned
> script, which does not exit properly), userspace is at fault,
> not the kernel.
>
> Guenter
Thank you for the quick response, Guenter. I see the log each time when I reboot my system, and when I searched the message in google, I also found posts asking why the message is printed at reboot, and that's why I feel it's confusing.
Anyways, please ignore the patch since it's necessary.
Thanks,
Tao Ren
next prev parent reply other threads:[~2018-11-16 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 23:44 [PATCH] watchdog: core: suppress "watchdog did not stop" message Tao Ren
2018-11-16 0:19 ` Guenter Roeck
2018-11-16 0:37 ` Tao Ren [this message]
2018-11-27 1:31 ` Jerry Hoemann
2018-11-27 6:11 ` Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a43bb84-f476-d6c8-886a-2120312ee8e7@fb.com \
--to=taoren@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).