From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Marco Felsch <m.felsch@pengutronix.de>,
Support Opensource <Support.Opensource@diasemi.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
Steve Twiss <stwiss.opensource@diasemi.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [PATCH] watchdog: da9062: do not ping the hw during stop()
Date: Tue, 28 Jan 2020 10:13:33 +0000 [thread overview]
Message-ID: <AM6PR10MB2263D6F62A45568D5671377D800A0@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20200120091729.16256-1-m.felsch@pengutronix.de>
On 20 January 2020 09:17, Marco Felsch wrote:
> The da9062 hw has a minimum ping cool down phase of at least 200ms. The
> driver takes that into account by setting the min_hw_heartbeat_ms to
> 300ms and the core guarantees that the hw limit is observed for the
> ping() calls. But the core can't guarantees the required minimum ping
> cool down phase if a stop() command is send immediately after the ping()
> command. So it is not allowed to ping the watchdog within the stop()
> command as the driver do. Remove the ping can be done without doubts
> because the watchdog gets disabled anyway and a (re)start reset the
> watchdog counter too.
>
Good spot. Thanks for this. Am wondering if this might also be an issue for
da9062_wdt_set_timeout() which calls down to
da9062_wdt_update_timeout_register() which in turn pings the watchdog first
before disabling it and then setting the new timeout value. I think it makes
sense to remove the ping from da9062_wdt_update_timeout_register() as well to
avoid any possible issues where a ping() is called and then immediately after
there's a call to adjust the timeout. If you can double check my hypothesis
that would be good though.
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> drivers/watchdog/da9062_wdt.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c
> index 77b6b5336067..0ad15d55071c 100644
> --- a/drivers/watchdog/da9062_wdt.c
> +++ b/drivers/watchdog/da9062_wdt.c
> @@ -97,13 +97,6 @@ static int da9062_wdt_stop(struct watchdog_device *wdd)
> struct da9062_watchdog *wdt = watchdog_get_drvdata(wdd);
> int ret;
>
> - ret = da9062_reset_watchdog_timer(wdt);
> - if (ret) {
> - dev_err(wdt->hw->dev, "Failed to ping the watchdog (err =
> %d)\n",
> - ret);
> - return ret;
> - }
> -
> ret = regmap_update_bits(wdt->hw->regmap,
> DA9062AA_CONTROL_D,
> DA9062AA_TWDSCALE_MASK,
> --
> 2.20.1
prev parent reply other threads:[~2020-01-28 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 9:17 [PATCH] watchdog: da9062: do not ping the hw during stop() Marco Felsch
2020-01-25 23:11 ` Guenter Roeck
2020-01-28 10:13 ` Adam Thomson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR10MB2263D6F62A45568D5671377D800A0@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.felsch@pengutronix.de \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).