From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC06C4338F for ; Mon, 26 Jul 2021 09:20:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9593760C51 for ; Mon, 26 Jul 2021 09:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232434AbhGZIjw (ORCPT ); Mon, 26 Jul 2021 04:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232173AbhGZIjw (ORCPT ); Mon, 26 Jul 2021 04:39:52 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23ACFC061760 for ; Mon, 26 Jul 2021 02:20:21 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id r26so14250862lfp.5 for ; Mon, 26 Jul 2021 02:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UyAhVW8SUVdW2juHf4NXSIfTyUpw2d4E9HcLC6UlbsU=; b=PFhaUyyioW4u4jvnVZfDpQc+0BSgWt8O5W+h2/JkXloGBxxa1lz6qvX+LcbuUXQc2N Z/sV52rf44gz4YnpyNlA3a5x50wV6yKSQCx7U00BnemtwgGM+ascTy/4/9Bei7pKU0i6 ejhLDXqu6p6hD3mYKZgz79DXesDgefxzliTwg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UyAhVW8SUVdW2juHf4NXSIfTyUpw2d4E9HcLC6UlbsU=; b=FjtY0j39mj4N6z3wbOBrc2lDngxEtfMi9QzBhAnE00FnYzf5fTigShfUXF0P4Z9C12 LWvEmLecW336EZkRzWA5sllAb64pf1jnqQb7m63a6DTOZYSDHvE0E8CPr56X/hKU7ZTU hgurvJt6bFDtxKCKkv/INF6S39TT5tLQzDla0XRhiyKxDoZMJVm01v2qBMGo6l4AxH/X 09lxNRLnZGmjh0hBvuWewsTUHS7SgU05SMWeBSuF1fOaZ7PJ8cLwpHOodnwQVJJyzURX czvAdDHdLR76DT/9HVjbLNfPskg6QtmLu63XQktMOExePwO+va/vmchIYzg3PKcRLHAY T1HQ== X-Gm-Message-State: AOAM532VjFwJKwe/nHtza2ei5tKJxoJQgZylgzKK25Wi17eNKFo89yo8 eK2+MLLRuFvs1hQ8ggVikMJh4XkMp9DlAnhEQa7uYQ== X-Google-Smtp-Source: ABdhPJxZeDoaO4+lBiCkXyq/2Admv1+kefRfVNjKKrFIMZn357CPp9SKVLhT5mJJhxTofCy8T41M60sD5j6u/8BBBOQ= X-Received: by 2002:ac2:48b8:: with SMTP id u24mr12319860lfg.587.1627291219448; Mon, 26 Jul 2021 02:20:19 -0700 (PDT) MIME-Version: 1.0 References: <20210726071439.14248-1-sam.shih@mediatek.com> <20210726071439.14248-2-sam.shih@mediatek.com> In-Reply-To: <20210726071439.14248-2-sam.shih@mediatek.com> From: Chen-Yu Tsai Date: Mon, 26 Jul 2021 17:20:08 +0800 Message-ID: Subject: Re: [PATCH 01/12] dt-bindings: clock: mediatek: document clk bindings for mediatek mt7986 SoC To: Sam Shih Cc: Rob Herring , Sean Wang , Linus Walleij , Matthias Brugger , Matt Mackall , Herbert Xu , Greg Kroah-Hartman , Wim Van Sebroeck , Guenter Roeck , Michael Turquette , Stephen Boyd , Hsin-Yi Wang , Enric Balletbo i Serra , Fabien Parent , Seiya Wang , Devicetree List , LKML , "moderated list:ARM/Mediatek SoC support" , linux-gpio@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-crypto@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-clk@vger.kernel.org, John Crispin , Ryder Lee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Mon, Jul 26, 2021 at 3:17 PM Sam Shih wrote: > > This patch adds the binding documentation for topckgen, apmixedsys, > infracfg, infracfg_ao, and ethernet subsystem clocks. > > Signed-off-by: Sam Shih > --- > .../devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt | 1 + > .../devicetree/bindings/arm/mediatek/mediatek,ethsys.txt | 1 + > .../devicetree/bindings/arm/mediatek/mediatek,infracfg.txt | 2 ++ > .../devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt | 2 ++ > .../devicetree/bindings/arm/mediatek/mediatek,topckgen.txt | 1 + > 5 files changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt > index ea827e8763de..3fa755866528 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt > @@ -14,6 +14,7 @@ Required Properties: > - "mediatek,mt7622-apmixedsys" > - "mediatek,mt7623-apmixedsys", "mediatek,mt2701-apmixedsys" > - "mediatek,mt7629-apmixedsys" > + - "mediatek,mt7986-apmixedsys" > - "mediatek,mt8135-apmixedsys" > - "mediatek,mt8167-apmixedsys", "syscon" > - "mediatek,mt8173-apmixedsys" > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt > index 6b7e8067e7aa..0502db73686b 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt > @@ -10,6 +10,7 @@ Required Properties: > - "mediatek,mt7622-ethsys", "syscon" > - "mediatek,mt7623-ethsys", "mediatek,mt2701-ethsys", "syscon" > - "mediatek,mt7629-ethsys", "syscon" > + - "mediatek,mt7986-ethsys", "syscon" > - #clock-cells: Must be 1 > - #reset-cells: Must be 1 > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt > index eb3523c7a7be..5f68c30162bf 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt > @@ -15,6 +15,8 @@ Required Properties: > - "mediatek,mt7622-infracfg", "syscon" > - "mediatek,mt7623-infracfg", "mediatek,mt2701-infracfg", "syscon" > - "mediatek,mt7629-infracfg", "syscon" > + - "mediatek,mt7986-infracfg", "syscon" > + - "mediatek,mt7986-infracfg_ao", "syscon" > - "mediatek,mt8135-infracfg", "syscon" > - "mediatek,mt8167-infracfg", "syscon" > - "mediatek,mt8173-infracfg", "syscon" > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > index 30cb645c0e54..0e1184392941 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt > @@ -8,6 +8,8 @@ Required Properties: > - compatible: Should be: > - "mediatek,mt7622-sgmiisys", "syscon" > - "mediatek,mt7629-sgmiisys", "syscon" > + - "mediatek,mt7986-sgmiisys", "mediatek,mt7986-sgmiisys_0", "syscon" > + - "mediatek,mt7986-sgmiisys", "mediatek,mt7986-sgmiisys_1", "syscon" The order should be: most specific compatible string first, followed by fallbacks. Furthermore, based on the driver patch and the fact that they share the same compatible string, it seems you shouldn't need to have two compatible strings for two identical hardware blocks. The need for separate entries to have different clock names is an implementation detail. Please consider using and supporting clock-output-names. Also, please check out the MT8195 clock driver series [1]. I'm guessing a lot of the comments apply to this one as well. Regards ChenYu [1] https://lore.kernel.org/linux-mediatek/20210616224743.5109-1-chun-jie.chen@mediatek.com/T/#t > - #clock-cells: Must be 1 > > The SGMIISYS controller uses the common clk binding from > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt > index 5ce7578cf274..b82422bb717f 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt > @@ -14,6 +14,7 @@ Required Properties: > - "mediatek,mt7622-topckgen" > - "mediatek,mt7623-topckgen", "mediatek,mt2701-topckgen" > - "mediatek,mt7629-topckgen" > + - "mediatek,mt7986-topckgen", "syscon" > - "mediatek,mt8135-topckgen" > - "mediatek,mt8167-topckgen", "syscon" > - "mediatek,mt8173-topckgen" > -- > 2.29.2 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek