From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Jean Delvare <jdelvare@suse.de>,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, Tom Abraham <tabraham@suse.com>
Subject: Re: Forcing non-ACPI watchdog driver
Date: Thu, 6 Feb 2020 16:50:00 +0100 [thread overview]
Message-ID: <CAJZ5v0i5+DaFM22jW=dS66JHK5=ydvMf4dBuJTMvGoNSZLOL3Q@mail.gmail.com> (raw)
In-Reply-To: <20200206145602.GQ2667@lahna.fi.intel.com>
On Thu, Feb 6, 2020 at 3:56 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Thu, Feb 06, 2020 at 03:45:32PM +0100, Jean Delvare wrote:
> > Hi Mika,
> >
> > On Wed, 5 Feb 2020 18:38:31 +0200, Mika Westerberg wrote:
> > > On Wed, Feb 05, 2020 at 08:30:48AM -0800, Guenter Roeck wrote:
> > > > On Wed, Feb 05, 2020 at 05:24:35PM +0200, Mika Westerberg wrote:
> > > > > You should be able to revert to iTCO_wdt by simply disabling
> > > > > CONFIG_WDAT_WDT from .config. Then acpi_has_watchdog() returns false
> > > > > which means that iTCO_wdt is used instead.
> > > >
> > > > That may not be possible in a generic distribution.
> > >
> > > Right, they would need to build their own kernel. Currently there is no
> > > way to do that without changing .config.
> >
> > OK, that's pretty much what I was compl^Wworried about ;-) Would you
> > consider applying something like the following patch?
>
> Yes, I think the patch makes sense.
>
> Rafael, I guess you will take this since it is touching ACPI?
Yes, I will.
> > From: Jean Delvare <jdelvare@suse.de>
> > Subject: ACPI / watchdog: Allow disabling WDAT at boot
> >
> > In case the WDAT interface is broken, give the user the option to
> > ignore it to let a native driver bind to the watchdog device instead.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks!
next prev parent reply other threads:[~2020-02-06 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 15:05 Forcing non-ACPI watchdog driver Jean Delvare
2020-02-05 15:24 ` Mika Westerberg
2020-02-05 16:30 ` Guenter Roeck
2020-02-05 16:38 ` Mika Westerberg
2020-02-06 14:45 ` Jean Delvare
2020-02-06 14:56 ` Mika Westerberg
2020-02-06 15:50 ` Rafael J. Wysocki [this message]
2020-02-06 16:00 ` Rafael J. Wysocki
2020-02-06 19:14 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0i5+DaFM22jW=dS66JHK5=ydvMf4dBuJTMvGoNSZLOL3Q@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=jdelvare@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=tabraham@suse.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).