From: Arnd Bergmann <arnd@arndb.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Ungerer <gerg@uclinux.org>,
Linus Walleij <linus.walleij@linaro.org>,
arm-soc <arm@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 1/6] ARM: ks8695: watchdog: stop using mach/*.h
Date: Mon, 15 Apr 2019 22:58:49 +0200 [thread overview]
Message-ID: <CAK8P3a1sSt7YVJk6P_0bPYPONqWzNd+3pya265gNOdjr6=abrg@mail.gmail.com> (raw)
In-Reply-To: <20190415205410.GA31583@roeck-us.net>
On Mon, Apr 15, 2019 at 10:54 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> >
> > config KS8695_WATCHDOG
> > tristate "KS8695 watchdog"
> > - depends on ARCH_KS8695
> > + depends on ARCH_KS8695 || COMPILE_TEST
>
> Is __raw_readl / __raw_writel really available for all architectures / platforms ?
I'm fairly sure it is these days, only uml and s390 used to be the
exceptions here, but they both added this.
It's possible that something else is missing, I was hoping for the 0-day
bot to tell me if so.
> > @@ -238,6 +237,11 @@ static struct miscdevice ks8695wdt_miscdev = {
> > static int ks8695wdt_probe(struct platform_device *pdev)
> > {
> > int res;
> > + struct resource *resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +
> > + tmr_reg = devm_ioremap_resource(&pdev->dev, resource);
>
> Please use devm_platform_ioremap_resource().
Ah, that is the function I was looking for, thanks for the hint.
Arnd
next prev parent reply other threads:[~2019-04-15 20:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 20:24 [PATCH 1/6] ARM: ks8695: watchdog: stop using mach/*.h Arnd Bergmann
2019-04-15 20:54 ` Guenter Roeck
2019-04-15 20:58 ` Arnd Bergmann [this message]
2019-04-16 13:21 ` [PATCH 1/6 v2] " Arnd Bergmann
2019-04-16 18:09 ` Guenter Roeck
2019-04-20 2:36 ` [PATCH 1/6] " Greg Ungerer
2019-05-03 7:02 ` Greg Ungerer
2019-05-03 7:16 ` Linus Walleij
2019-05-03 17:06 ` Guenter Roeck
2019-05-04 14:26 ` Greg Ungerer
2019-07-22 14:44 ` Arnd Bergmann
2019-07-22 20:13 ` Olof Johansson
2019-07-29 12:53 ` Greg Ungerer
2019-07-29 15:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1sSt7YVJk6P_0bPYPONqWzNd+3pya265gNOdjr6=abrg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=gerg@uclinux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).