RE: [PATCH] watchdog: aspeed_wdt: Reorder output signal register configuration

[Bonnie Lo/WYHQ/Wiwynn <Bonnie_Lo@wiwynn.com>]

> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Friday, August 19, 2022 7:45 PM
> To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> Cc: wim@linux-watchdog.org; joel@jms.id.au; andrew@aj.id.au;
> BMC-SW@aspeedtech.com; linux-watchdog@vger.kernel.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> openbmc@lists.ozlabs.org; Bonnie Lo/WYHQ/Wiwynn
> <Bonnie_Lo@wiwynn.com>
> Subject: Re: [PATCH] watchdog: aspeed_wdt: Reorder output signal register
> configuration
>
>   Security Reminder: Please be aware that this email was sent by an
> external sender.
>
> On Fri, Aug 19, 2022 at 05:49:05PM +0800, Chin-Ting Kuo wrote:
> > If the output driving type is push-pull mode, the output polarity
> > should be selected in advance. Otherwise, an unexpected value will be
> > output at the moment of changing to push-pull mode.
> > Thus, output polarity, WDT18[31], must be configured before changing
> > driving type, WDT18[30].
> >
> > Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>

Tested-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>

> > ---
> >  drivers/watchdog/aspeed_wdt.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/watchdog/aspeed_wdt.c
> > b/drivers/watchdog/aspeed_wdt.c index 436571b6fc79..a03e4ff812a2
> > 100644
> > --- a/drivers/watchdog/aspeed_wdt.c
> > +++ b/drivers/watchdog/aspeed_wdt.c
> > @@ -325,18 +325,18 @@ static int aspeed_wdt_probe(struct
> platform_device *pdev)
> >               u32 reg = readl(wdt->base + WDT_RESET_WIDTH);
> >
> >               reg &= config->ext_pulse_width_mask;
> > -             if (of_property_read_bool(np, "aspeed,ext-push-pull"))
> > -                     reg |= WDT_PUSH_PULL_MAGIC;
> > +             if (of_property_read_bool(np, "aspeed,ext-active-high"))
> > +                     reg |= WDT_ACTIVE_HIGH_MAGIC;
> >               else
> > -                     reg |= WDT_OPEN_DRAIN_MAGIC;
> > +                     reg |= WDT_ACTIVE_LOW_MAGIC;
> >
> >               writel(reg, wdt->base + WDT_RESET_WIDTH);
> >
> >               reg &= config->ext_pulse_width_mask;
> > -             if (of_property_read_bool(np, "aspeed,ext-active-high"))
> > -                     reg |= WDT_ACTIVE_HIGH_MAGIC;
> > +             if (of_property_read_bool(np, "aspeed,ext-push-pull"))
> > +                     reg |= WDT_PUSH_PULL_MAGIC;
> >               else
> > -                     reg |= WDT_ACTIVE_LOW_MAGIC;
> > +                     reg |= WDT_OPEN_DRAIN_MAGIC;
> >
> >               writel(reg, wdt->base + WDT_RESET_WIDTH);
> >       }
> > --
> > 2.25.1
> >
WIWYNN PROPRIETARY This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.