From: Qiang Zhao <qiang.zhao@nxp.com>
To: Guenter Roeck <linux@roeck-us.net>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] watchdog: sbsa_gwdt: add shutdown hook to driver
Date: Thu, 27 Aug 2020 07:55:31 +0000 [thread overview]
Message-ID: <VE1PR04MB67681C26D81E855A152043BE91550@VE1PR04MB6768.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <cdfd0c4d-3433-f952-0e49-ebc0f7474e1a@roeck-us.net>
On 8/24/20 21:29 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: 2020年8月24日 21:29
> To: Qiang Zhao <qiang.zhao@nxp.com>; wim@linux-watchdog.org
> Cc: linux-watchdog@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] watchdog: sbsa_gwdt: add shutdown hook to driver
>
> On 8/24/20 1:18 AM, Qiang Zhao wrote:
> > From: Zhao Qiang <qiang.zhao@nxp.com>
> >
> > Kexec maybe need more time than timeout of wdt(sbsa) which will reset
> > the system.
> > So it is necessary to add shutdown hook to disable the wdt when run
> > kexec.
> >
>
> Please explain why watchdog_stop_on_reboot() does not work.
>
Thank you for your comments, it is helpful.
I investigate this issue again, found that this watchdog are enabled by uboot,
Meanwhile in kernel, it is not the default watchdog, in another words, it is not active in kernel.
So watchdog_stop_on_reboot() does not work.
This patch is not the right solution for the situation, I will abandon it.
Best Regards
Qiang Zhao
next prev parent reply other threads:[~2020-08-27 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 8:18 [PATCH] watchdog: sbsa_gwdt: add shutdown hook to driver Qiang Zhao
2020-08-24 13:28 ` Guenter Roeck
2020-08-27 7:55 ` Qiang Zhao [this message]
2020-08-27 16:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB67681C26D81E855A152043BE91550@VE1PR04MB6768.eurprd04.prod.outlook.com \
--to=qiang.zhao@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).