From: Guenter Roeck <linux@roeck-us.net>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, wim@linux-watchdog.org
Cc: p.zabel@pengutronix.de, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h
Date: Wed, 12 May 2021 20:15:05 -0700 [thread overview]
Message-ID: <b885c7ac-2e25-6a03-4434-d0b31f92a15a@roeck-us.net> (raw)
In-Reply-To: <1620871503-100900-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On 5/12/21 7:05 PM, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
>
> ./drivers/watchdog/dw_wdt.c: linux/kernel.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/watchdog/dw_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e17..b1642e2 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -19,7 +19,6 @@
> #include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> #include <linux/interrupt.h>
>
When making such changes, please use the opportunity to reorder include files
in alphabetic order to help ensure that duplicate includes don't happen again.
Thanks,
Guenter
prev parent reply other threads:[~2021-05-13 3:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 2:05 [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h Jiapeng Chong
2021-05-13 3:15 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b885c7ac-2e25-6a03-4434-d0b31f92a15a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).